#1353 - fix for unable to add items to nested list#1354
Closed
joncarlson wants to merge 1 commit intorjsf-team:masterfrom
joncarlson:nested-array-fix
Closed
#1353 - fix for unable to add items to nested list#1354joncarlson wants to merge 1 commit intorjsf-team:masterfrom joncarlson:nested-array-fix
joncarlson wants to merge 1 commit intorjsf-team:masterfrom
joncarlson:nested-array-fix
Conversation
Author
|
Looks like that block of code has been changed, will do some testing to see if the problem still exists |
Author
|
Ok, this recently merged PR actually fixed the issue: #1335 Closing this PR as it's unnecessary now |
Member
|
Oh cool, that's great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Related issue: #1353
A JS error is thrown when attempting to add an item to a new inner list of a nested list.
This blocks a user from adding items to a nested list.
Checklist