Skip to content

#1353 - fix for unable to add items to nested list#1354

Closed
joncarlson wants to merge 1 commit intorjsf-team:masterfrom
joncarlson:nested-array-fix
Closed

#1353 - fix for unable to add items to nested list#1354
joncarlson wants to merge 1 commit intorjsf-team:masterfrom
joncarlson:nested-array-fix

Conversation

@joncarlson
Copy link

Reasons for making this change

Related issue: #1353

A JS error is thrown when attempting to add an item to a new inner list of a nested list.

This blocks a user from adding items to a nested list.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@joncarlson
Copy link
Author

Looks like that block of code has been changed, will do some testing to see if the problem still exists

@joncarlson
Copy link
Author

Ok, this recently merged PR actually fixed the issue: #1335

Closing this PR as it's unnecessary now

@joncarlson joncarlson closed this Jul 11, 2019
@epicfaace
Copy link
Member

Oh cool, that's great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants