Allows for a custom tagName to be used in place of "form"#1345
Allows for a custom tagName to be used in place of "form"#1345epicfaace merged 1 commit intorjsf-team:masterfrom
Conversation
|
Looks great, thanks! Can you add a test for it? I'm also wondering if not having a |
7c1fddc to
1686d8b
Compare
|
I added a test. I cannot think of any obvious other than the default native browser behaviour might not work. But I would imagine that if you were manually changing the |
|
@juliankigwana that makes sense. Can you add that bit as a warning in the documentation? (that the native browser behavior might not work) |
|
Additionally, the only allowed values for tagName will be valid JSX HTML tags, correct? Can you add a test in which one tries an invalid tagName? |
I'm not sure we can test for it. Most browsers will render an unknown I shall update the documentation with the warning and something saying it expects a valid HTML tag. |
1686d8b to
630b47d
Compare
epicfaace
left a comment
There was a problem hiding this comment.
Makes sense, thanks! Can you apply this suggestion -- and then we'll be good to merge this.
630b47d to
ade90c4
Compare
|
Thanks @epicfaace. I did apply the suggestion, but it's still showing here as changes requested. Do I need to do anything else? |
|
Nope, looks good -- thanks! |

Reasons for making this change
Sometimes we need a way to nest the RJSF components so that we can utilise the rendering capabilities within our components. For example, when rendering a custom
Array<Object>component, the child properties can be rendered in a child form. However doing this will produce invalid html, a nasty error in the console, and possibly cause unforeseen problems across browsers.Checklist