Merged
Conversation
- Remove deprecated `babel-plugin-react-transform` with `@babel/plugin-transform-react-jsx` - Update a few files with default exports as they were throwing warnings while running `dev`
epicfaace
approved these changes
Jun 17, 2019
Member
epicfaace
left a comment
There was a problem hiding this comment.
Looks good, thanks for making this change! Can you mark this pull request as "ready for review" if you're done?
You don't need to add a version bump; usually @glasserc does that when releasing a new version with the latest pull requests. I would think this would only be a patch version bump because it is just updating development tools, not the actual functionality of the library itself.
Contributor
Author
|
@epicfaace Marked this PR as 'ready for review' :) |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Using my work account (@ankurkaushal360), I opened an issue here, #1319 mentioning
babelupgrade & I was told to it would be a good idea.So this pull upgrades the Babel 6 to Babel 7 using
npx babel-upgrade --writeand does the following things:babel-plugin-react-transformwith@babel/plugin-transform-react-jsxdefaultexports as they were throwing warnings while runningdevlike this:As far as I can tell, everything should work as it is. Even all the tests are passing too. I don't think I need to add / update any tests for this change.
Also, I haven't updated the
package.jsonversion yet. Though I think I need to update it. Would you prefermajororminorversion bump?Checklist
npm run cs-formaton my branch to conform my code to prettier coding style