Correctly use $ref when matching options with oneOf#1287
Merged
Conversation
Fixes #1173 Additionally, if a matching option isn't found, preserve the currently selected option Change-type: patch Signed-off-by: Lucian <lucian.buzzo@gmail.com>
|
@LucianBuzzo - Thanks for taking a look at this so quickly. I have another example that I believe is the same or at least similar and doesn't work as expected on the branch for this issue. If you want a new issue for this please let me know. |
epicfaace
reviewed
May 19, 2019
Collaborator
Author
|
@bdgeise Would you be able to open a new issue for the unexpected behaviour please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1173
Additionally, if a matching option isn't found, preserve the currently
selected option
Change-type: patch
Signed-off-by: Lucian lucian.buzzo@gmail.com
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style