Skip to content

Comments

Correctly use $ref when matching options with oneOf#1287

Merged
epicfaace merged 2 commits intomasterfrom
1173-oneof-match-ref
May 19, 2019
Merged

Correctly use $ref when matching options with oneOf#1287
epicfaace merged 2 commits intomasterfrom
1173-oneof-match-ref

Conversation

@LucianBuzzo
Copy link
Collaborator

Fixes #1173

Additionally, if a matching option isn't found, preserve the currently
selected option

Change-type: patch
Signed-off-by: Lucian lucian.buzzo@gmail.com

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

Fixes #1173

Additionally, if a matching option isn't found, preserve the currently
selected option

Change-type: patch
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
@bdgeise
Copy link

bdgeise commented May 17, 2019

@LucianBuzzo - Thanks for taking a look at this so quickly. I have another example that I believe is the same or at least similar and doesn't work as expected on the branch for this issue. If you want a new issue for this please let me know.

https://mozilla-services.github.io/react-jsonschema-form/#eyJmb3JtRGF0YSI6eyJzdGVwcyI6W3siYWN0aW9ucyI6W3sidmFsdWUiOnsicnVsZXMiOlt7Im9wZXJhdG9yIjoiYW5kIn1dfX1dfV0sImZpcnN0TmFtZSI6IkNodWNrIiwibGFzdE5hbWUiOiJOb3JyaXMiLCJhZ2UiOjc1LCJiaW8iOiJSb3VuZGhvdXNlIGtpY2tpbmcgYXNzZXMgc2luY2UgMTk0MCIsInBhc3N3b3JkIjoibm9uZWVkIn0sInNjaGVtYSI6eyJkZWZpbml0aW9ucyI6eyJmaWx0ZXJUeXBlIjp7InR5cGUiOiJvYmplY3QiLCJwcm9wZXJ0aWVzIjp7Im9wZXJhdG9yIjp7InR5cGUiOiJzdHJpbmcifSwicnVsZXMiOnsidHlwZSI6ImFycmF5IiwiaXRlbXMiOnsib25lT2YiOlt7InR5cGUiOiJvYmplY3QiLCJwcm9wZXJ0aWVzIjp7ImZpZWxkIjp7InRpdGxlIjoiRmlsdGVyIGZpZWxkIiwidHlwZSI6InN0cmluZyJ9LCJvcGVyYXRvciI6eyJ0aXRsZSI6IkZpbHRlciBjb25kaXRpb24gb3BlcmF0b3IiLCJ0eXBlIjoic3RyaW5nIn0sInZhbHVlIjp7InRpdGxlIjoiVmFsdWVzIHRvIGZpbHRlciBvbiIsInR5cGUiOiJhcnJheSIsIml0ZW1zIjp7Im9uZU9mIjpbeyJ0aXRsZSI6IlN0cmluZyBUeXBlIiwidHlwZSI6InN0cmluZyJ9LHsidGl0bGUiOiJOdW1lcmljIFR5cGUiLCJ0eXBlIjoibnVtYmVyIn1dfX19fSx7InR5cGUiOiJvYmplY3QiLCIkcmVmIjoiIy9kZWZpbml0aW9ucy9maWx0ZXJUeXBlIn1dfX19fSwiZmllbGQiOnsidHlwZSI6Im9iamVjdCIsInByb3BlcnRpZXMiOnsidmFsdWUiOnsidHlwZSI6InN0cmluZyJ9LCJhbGlhcyI6eyJ0eXBlIjoic3RyaW5nIn19fSwiZmllbGRFaXRoZXIiOnsidHlwZSI6Im9iamVjdCIsIm9uZU9mIjpbeyJ0aXRsZSI6IlNpbXBsZSBmaWVsZCIsIiRyZWYiOiIjL2RlZmluaXRpb25zL2ZpZWxkIn0seyJ0aXRsZSI6IkNvbXBsZXggZmllbGQiLCJ0eXBlIjoib2JqZWN0IiwicHJvcGVydGllcyI6eyJ2YWx1ZSI6eyJ0eXBlIjoiYXJyYXkiLCJpdGVtcyI6eyIkcmVmIjoiIy9kZWZpbml0aW9ucy9maWVsZEVpdGhlciJ9fSwiYWxpYXMiOnsidHlwZSI6InN0cmluZyJ9fX1dfX0sInR5cGUiOiJvYmplY3QiLCJwcm9wZXJ0aWVzIjp7Im5hbWUiOnsidHlwZSI6InN0cmluZyJ9LCJ2ZW5kb3IiOnsidHlwZSI6InN0cmluZyJ9LCJzdGVwcyI6eyJ0eXBlIjoiYXJyYXkiLCJtaW5JdGVtcyI6MSwiaXRlbXMiOnsidHlwZSI6Im9iamVjdCIsInByb3BlcnRpZXMiOnsic3RlcF9uYW1lIjp7InR5cGUiOiJzdHJpbmcifSwiYWN0aW9ucyI6eyJ0eXBlIjoiYXJyYXkiLCJtaW5JdGVtcyI6MSwiaXRlbXMiOnsidHlwZSI6Im9iamVjdCIsInByb3BlcnRpZXMiOnsidHlwZSI6eyJ0aXRsZSI6IkFjdGlvbiBUeXBlIiwiZGVzY3JpcHRpb24iOiJUeXBlIG9mIGFjdGlvbiB0byBiZSBwZXJmb3JtZWQiLCJ0eXBlIjoic3RyaW5nIn0sIm5hbWUiOnsidGl0bGUiOiJBY3Rpb24gTmFtZSIsImRlc2NyaXB0aW9uIjoiSHVtYW4gZnJpZW5kbHkgYWN0aW9uIG5hbWUiLCJ0eXBlIjoic3RyaW5nIn0sInZhbHVlIjp7InRpdGxlIjoiQWN0aW9uIGRlZmluaXRpb24iLCJkZXNjcmlwdGlvbiI6IkRlZmluaXRpb24gZGVmaW5pbmcgdGhlIGFjdGlvbiIsIm9uZU9mIjpbeyJ0aXRsZSI6IkZpbHRlciIsInR5cGUiOiJvYmplY3QiLCIkcmVmIjoiIy9kZWZpbml0aW9ucy9maWx0ZXJUeXBlIn1dfX19fX19fX19LCJ1aVNjaGVtYSI6eyJmaXJzdE5hbWUiOnsidWk6YXV0b2ZvY3VzIjp0cnVlLCJ1aTplbXB0eVZhbHVlIjoiIn0sImFnZSI6eyJ1aTp3aWRnZXQiOiJ1cGRvd24iLCJ1aTp0aXRsZSI6IkFnZSBvZiBwZXJzb24iLCJ1aTpkZXNjcmlwdGlvbiI6IihlYXJ0aGlhbiB5ZWFyKSJ9LCJiaW8iOnsidWk6d2lkZ2V0IjoidGV4dGFyZWEifSwicGFzc3dvcmQiOnsidWk6d2lkZ2V0IjoicGFzc3dvcmQiLCJ1aTpoZWxwIjoiSGludDogTWFrZSBpdCBzdHJvbmchIn0sImRhdGUiOnsidWk6d2lkZ2V0IjoiYWx0LWRhdGV0aW1lIn0sInRlbGVwaG9uZSI6eyJ1aTpvcHRpb25zIjp7ImlucHV0VHlwZSI6InRlbCJ9fX19

Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! And this will fix #1176 and similar issues as well.

@epicfaace epicfaace merged commit 67d17dd into master May 19, 2019
@epicfaace epicfaace deleted the 1173-oneof-match-ref branch May 19, 2019 19:41
@LucianBuzzo
Copy link
Collaborator Author

LucianBuzzo commented May 20, 2019

@bdgeise Would you be able to open a new issue for the unexpected behaviour please?
There is a lot of complicated logic going on here, and I'd like to separate out bugs into different issues/prs as much as possible.

@bdgeise
Copy link

bdgeise commented May 20, 2019

@bdgeise Would you be able to open a new issue for the unexpected behaviour please?
There is a lot of complicated logic going on here, and I'd like to separate out bugs into different issues/prs as much as possible.

Yep - #1288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with nesting oneOf inside an array that is inside of an object.

3 participants