Skip to content

Fix/warn unknown formats#1277

Merged
epicfaace merged 3 commits intomasterfrom
fix/warn-unknown-formats
May 7, 2019
Merged

Fix/warn unknown formats#1277
epicfaace merged 3 commits intomasterfrom
fix/warn-unknown-formats

Conversation

@epicfaace
Copy link
Member

Reasons for making this change

Fixes #961. Allows for unknown formats to still work as per the JSON schema spec. Does the following:

  • console warn on unknown format errors instead of showing an error
  • default to default widget if the string format is not found (otherwise, providing an unknown format will look for a widget for that format, then fail)

If this is related to existing tickets, include links to them as well.

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@epicfaace epicfaace requested a review from edi9999 May 6, 2019 22:11
@epicfaace epicfaace merged commit fba5bee into master May 7, 2019
@epicfaace epicfaace deleted the fix/warn-unknown-formats branch May 7, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors when parsing schema with a 'format' attribute

2 participants