Skip to content

Comments

Make numbers nullable by allowing null values to be echoed from asNumber()#1269

Merged
epicfaace merged 2 commits intorjsf-team:masterfrom
glompix:nullable-numbers
May 7, 2019
Merged

Make numbers nullable by allowing null values to be echoed from asNumber()#1269
epicfaace merged 2 commits intorjsf-team:masterfrom
glompix:nullable-numbers

Conversation

@glompix
Copy link
Contributor

@glompix glompix commented Apr 26, 2019

Reasons for making this change

To allow ui:emptyValue=null for number fields. Fixes #1268

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@glompix
Copy link
Contributor Author

glompix commented Apr 26, 2019

This is available on npm as @glompix/react-jsonschema-form: 1.5.0 for pre-release availability.

@epicfaace
Copy link
Member

Looks good! Thanks! 😀

@epicfaace epicfaace merged commit 1ee343d into rjsf-team:master May 7, 2019
@glompix glompix deleted the nullable-numbers branch June 14, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui:emptyValue=null does not work with number inputs

2 participants