Skip to content

Ensure defaults are passed along for multiselect arrays when minItems…#1264

Merged
epicfaace merged 3 commits intorjsf-team:masterfrom
fsteger:issue-1258
Jun 3, 2019
Merged

Ensure defaults are passed along for multiselect arrays when minItems…#1264
epicfaace merged 3 commits intorjsf-team:masterfrom
fsteger:issue-1258

Conversation

@fsteger
Copy link
Contributor

@fsteger fsteger commented Apr 24, 2019

… present (#1258)

Reasons for making this change

When minItems is present for multi select array fields, the default value returned was always an empty array.

Addresses issue #1258

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@epicfaace
Copy link
Member

@fsteger thanks for the PR -- can you add a test for the case in which default is an array of items (such as the example in issue #1258)? It looks like the test you added is a duplicate of an existing test.

@epicfaace
Copy link
Member

Thanks!

@epicfaace epicfaace merged commit 41fce4a into rjsf-team:master Jun 3, 2019
@fsteger fsteger deleted the issue-1258 branch June 24, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants