#226 - restrict accepted mimetype#1242
Closed
gr8pathik wants to merge 3 commits intorjsf-team:masterfrom
Closed
Conversation
epicfaace
requested changes
Mar 28, 2019
| if (!help) { | ||
| // See #312: Ensure compatibility with old versions of React. | ||
| return <div />; | ||
| return null; |
Member
There was a problem hiding this comment.
Can you make these changes (returning null instead of <div>'s) in a separate PR?
Contributor
Author
There was a problem hiding this comment.
returning null instead of <div>'s PR is already merged. I dont know why this commits is showing here. Will remove that commits.
Contributor
Author
There was a problem hiding this comment.
A bit messed up with the reverting part. So creating new PR #1246. Please delete this PR if possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
If this is related to existing tickets, include links to them as well.
#226 - Restrict accepted mimetypes in file widget
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style