Fix #1233 : Exclude File object from isObject detection#1234
Fix #1233 : Exclude File object from isObject detection#1234epicfaace merged 2 commits intorjsf-team:masterfrom
Conversation
epicfaace
left a comment
epicfaace
left a comment
There was a problem hiding this comment.
Thanks! Just a small change.
epicfaace
left a comment
epicfaace
left a comment
There was a problem hiding this comment.
Can you rename this one test?
Co-Authored-By: oterral <oterral@users.noreply.github.com>
epicfaace
left a comment
epicfaace
left a comment
There was a problem hiding this comment.
Looks good! Since isObject is used in several other places in the code, too, I believe this PR fixes several other bugs that might not have even been reported yet. 🎉
|
Thx @epicfaace |
|
Since 1.4.0 I'm now getting this error when trying to create a form ReferenceError: File is not defined at isObject (/srv/node_modules/react-jsonschema-form/lib/utils.js:325:24) at getDefaultFormState (/srv/node_modules/react-jsonschema-form/lib/utils.js:288:8) at Form.getStateFromProps (/srv/node_modules/react-jsonschema-form/lib/components/Form.js:157:53) at new Form (/srv/node_modules/react-jsonschema-form/lib/components/Form.js:129:25) 1.3.0 works fine |
|
@davidb-e4s thanks for noting that, looks like a browser compatibility issue. Can you make an issue with this and put down your browser version? |
|
The issue in question is #1252. |
4 participants
Reasons for making this change
Fix #1233