Add the full source maps by default for development#1208
Merged
epicfaace merged 1 commit intorjsf-team:masterfrom Mar 6, 2019
Merged
Add the full source maps by default for development#1208epicfaace merged 1 commit intorjsf-team:masterfrom
epicfaace merged 1 commit intorjsf-team:masterfrom
Conversation
epicfaace
approved these changes
Mar 6, 2019
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
I'm adding the source mappings to the current dev deployment for debugging. I've checked that the dev server runs pretty much exactly as fast as before (for rebuilds), so I don't see any reason not to add them. I've decided not to add them to the production config for now, because I don't think it would just be as simple as changing one webpack config and it's most useful in development.
Fixes #1203