Limit cases where "required" attribute is used on checkboxes#1194
Merged
Limit cases where "required" attribute is used on checkboxes#1194
Conversation
Member
|
@LucianBuzzo What about this schema? |
epicfaace
reviewed
Feb 25, 2019
Member
@LucianBuzzo Just bumping this. |
Collaborator
Author
|
@epicfaace Thanks for the reminder, I'll hopefully get time to add this case this afternoon |
Fixes #338 If the "required" attribute is applied to a checkbox, then HTML5 validation will only pass if the checkbox is ticked. This is at odds with the JSON schema definition of "required" that simply requires that the key exists. This PR will make it so that the "required" HTML5 attribute will only be applied if the schema uses `{ const: true }` or `{ enum: [ true ] }`. Signed-off-by: Lucian <lucian.buzzo@gmail.com>
2516f97 to
1c39e4b
Compare
Collaborator
Author
|
@epicfaace I've added additional logic for handling cases where |
epicfaace
approved these changes
Mar 6, 2019
Member
|
Looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338
If the "required" attribute is applied to a checkbox, then HTML5
validation will only pass if the checkbox is ticked. This is at odds
with the JSON schema definition of "required" that simply requires that
the key exists.
This PR will make it so that the "required" HTML5 attribute will only be
applied if the schema uses
{ const: true }or{ enum: [ true ] }.Signed-off-by: Lucian lucian.buzzo@gmail.com
Reasons for making this change
[Please describe them here]
If this is related to existing tickets, include links to them as well.
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style