Improve handling of decimal points and trailing zeroes in numbers

[LucianBuzzo]

Fixes #674, fixes #958, fixes #966

Change-type: patch
Signed-off-by: Lucian lucian.buzzo@gmail.com

Checklist

• I'm updating documentation
  • I've checked the rendering of the Markdown text I've added
• I'm adding or updating code
  • I've added and/or updated tests
  • I've updated docs if needed
  • I've run npm run cs-format on my branch to conform my code to prettier coding style
• I'm adding a new feature
  • I've updated the playground with an example use of the feature

[epicfaace]

Looks great!

Also, I believe that with your changes, we can now drastically simplify the asNumber logic. I've made those changes in a separate branch and made a PR -- #1191 -- do let me know if you think I'm missing something and we actually do need this logic.

[epicfaace]

@LucianBuzzo can you fix the parentheses here?

Also, what is the scenario, exactly, in which there's a select with type=number with an option that has a trailing decimal point or multiple zeroes? Won't the schema never have these? Maybe if you can add a test for this it would be clearer.

[LucianBuzzo]

@epicfaace This logic needs to be here, because as you type in a value such as 0.001 each keystroke will trigger a change event, so the input will have to handle inputs like 0.00 as the user is typing. Additionally, you may have someone copy and paste values like 201.00 into the form, which is a valid number that you would expect to be processed correctly.

[LucianBuzzo]

@epicfaace I've addressed you're review comments. If it's alright with you I'd like to merge this PR and then review the changes to asNumber independently.

[epicfaace]

Looks good. Few things I noticed though:

When I copy and paste "201.00", the value in formData becomes a string "201.00", not the number 201.
When I enter in "0.001", the number input shows .001 instead of 0.001.

I think you're right, this is good to merge, we could fix these issues in a later PR.

[LucianBuzzo]

@epicfaace I couldn't reproduce the issue with pasting the value "201.00", could you post the schema you used to test it?
The issue with "0.001" is repeatable and a bit of a problem, I'll add some tests and fix it.

[epicfaace]

@LucianBuzzo I can't seem to reproduce the "201.00" issue, so I probably was using the wrong version earlier.

Other issues:

• I can't type in ".00"
• If I type in ".01", the number input only ends up with a "1"
• I can't paste in ".00" or "0.00"

[LucianBuzzo]

@epicfaace What do you think of automatically prefix . with a 0 so that if .00 is added it automatically becomes 0.00?

EDIT I worked on this and got it working nicely

[epicfaace]

Looks good! Will merge.