Conversation
edi9999
approved these changes
Feb 7, 2019
epicfaace
requested changes
Feb 7, 2019
Member
epicfaace
left a comment
There was a problem hiding this comment.
Looks good! I think it might be good to add a test for a const equal to a boolean and make sure the checkbox widget is rendered?
This change adds support for schemas that use the `const` keyword
without and adjacent `type` keyword. For example:
```json
{
"type": "object",
"properties": {
"firstName": {
"const": "Chuck"
}
}
}
```
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
9a3d3e0 to
7bb0912
Compare
Collaborator
Author
|
@epicfaace Good idea, I've added the test |
epicfaace
approved these changes
Feb 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for schemas that use the
constkeywordwithout and adjacent
typekeyword. For example:{ "type": "object", "properties": { "firstName": { "const": "Chuck" } } }Signed-off-by: Lucian lucian.buzzo@gmail.com
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style