Fix multiple bugs related to switching between anyOf/oneOf options#1169
Merged
Fix multiple bugs related to switching between anyOf/oneOf options#1169
Conversation
epicfaace
reviewed
Feb 8, 2019
Member
epicfaace
left a comment
epicfaace
left a comment
There was a problem hiding this comment.
Looks good, I just have a few questions about understanding the logic. Would appreciate if you could explain those a bit more!
| idSchema={idSchema[name]} | ||
| idPrefix={idPrefix} | ||
| formData={formData[name]} | ||
| formData={(formData || {})[name]} |
Member
There was a problem hiding this comment.
In what case(s) would formData be null?
Collaborator
Author
There was a problem hiding this comment.
formData can be null if you have just added an item to an array
Fixes #1168 - Fixed a bug that would prevent input fields from rendering when switching between a non-object type option and an object type option - Fixed a bug where options would incorrectly change when entering values if a subschema with multiple required fields is used - Fixed a bug where switching from an object tpye option to a non-object type option would result in an input field containing the value [Object object] Change-type: patch Signed-off-by: Lucian <lucian.buzzo@gmail.com>
LucianBuzzo
force-pushed
the
1168-oneof-missing-fields
branch
from
5187eda to
7d2961f
Compare
Collaborator
Author
|
@epicfaace Can you please re-review this PR when you have a chance? |
|
Do not mean to rush you @epicfaace , but excited for this fix to land ^_^. |
epicfaace
reviewed
Feb 21, 2019
epicfaace
reviewed
Feb 21, 2019
epicfaace
approved these changes
Feb 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1168
switching between a non-object type option and an object type option
values if a subschema with multiple required fields is used
type option would result in an input field containing the value [Object object]
Change-type: patch
Signed-off-by: Lucian lucian.buzzo@gmail.com
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style