Merged
Conversation
Contributor
Author
|
Just a regex tweak. |
Member
|
Thanks @jorgerobles, good work 😀-- can you add a test as you did in https://github.com/mozilla-services/react-jsonschema-form/pull/967/files? Probably it should involve making a custom widget which collects only the data uri, not the name. |
Contributor
Author
|
Really needed? If so I will do on weekend
El lun., 21 ene. 2019 19:16, Ashwin Ramaswami <notifications@github.com>
escribió:
… Thanks @jorgerobles <https://github.com/jorgerobles>, good work 😀-- can
you add a test as you did in
https://github.com/mozilla-services/react-jsonschema-form/pull/967/files?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1147 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABoIYF6vyHy-8DbMFK1aLCCrYu0Xyiz-ks5vFgQIgaJpZM4aLRY0>
.
|
Collaborator
|
It would be better indeed to have a regression test. |
epicfaace
requested changes
Jan 22, 2019
test/validate_test.js
Outdated
| errors = result.errors; | ||
| }); | ||
|
|
||
| it("Both should be fine", () => { |
Member
There was a problem hiding this comment.
Thanks for the test -- don't mean to be nitpicky, but it would really be great and cleaner if you could have separate it functions for the dataUrlWithName and a test case for dataUrlWithoutName.
Contributor
|
Thanks! |
KeroVieux
added a commit
to KeroVieux/react-jsonschema-form
that referenced
this pull request
Jan 25, 2019
* 'master' of github.com:KeroVieux/react-jsonschema-form: updated replace submit button paragraph tag with div (rjsf-team#766) Fixes rjsf-team#824 (rjsf-team#1147) Fix bug where matching anyOf branch is not selected correctly (rjsf-team#1129) Document a gotcha with `additionalProperties` (rjsf-team#1149) doc: add permalinks and fix internal hyperlinks in documentation doc: add doc build instructions, update PR/issue templates with doc links Add onBlur and onFocus events for radio and checkbox widgets (rjsf-team#1143) add ui:help tips (rjsf-team#1145) doc: fix browserstack logo size docs: remove docs from README and link to readthedocs rjsf-team#1138 doc: organize docs into separate files rjsf-team#1138 doc: add browserstack logo rjsf-team#990 Add test and update documentation for using anyOf inside array items (rjsf-team#1131) # Conflicts: # src/components/Form.js
LucianBuzzo
pushed a commit
that referenced
this pull request
Feb 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
See Issue #824, made name not required.
Checklist
npm run cs-formaton my branch to conform my code to prettier coding style