Fix custom boolean option labels using oneOf schemas #1137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
As previously reported in the following issues specifying boolean options with a oneOf schema does not work as expected.
These issues all essentially result from a lack of support for
oneOfin BooleanWidget altogether. This implements that support with a similar approach to theoptionsListutility.I've also added the ability to override
true/falseordering for boolean options by defining a customenum: [false, true]pair. This is entirely separate of oneOf but it makes behavior consistent between the two schema options.Checklist
npm run cs-formaton my branch to conform my code to prettier coding style