Skip to content

Fix failing unit tests related to time widget #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edi9999 merged 1 commit into from
Jan 7, 2019
Merged

Fix failing unit tests related to time widget #1119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/StringField_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,8 @@ describe("StringField", () => {
);

expect(lengths).eql([
121 + 1, // from 1900 to 2020 + undefined
// from 1900 to current year + 2 (inclusive) + 1 undefined option
Copy link
Copy Markdown

@cyplo cyplo Jan 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nitpick - but would it make sense to extract a function that provides this, to avoid duplication between tests ?

Copy link
Copy Markdown
Collaborator

@edi9999 edi9999 Jan 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is imo not really necessary, in tests duplication is not so bad.

new Date().getFullYear() - 1900 + 3 + 1,
12 + 1,
31 + 1,
24 + 1,
Expand Down Expand Up @@ -1019,7 +1020,8 @@ describe("StringField", () => {
);

expect(lengths).eql([
121 + 1, // from 1900 to 2020 + undefined
// from 1900 to current year + 2 (inclusive) + 1 undefined option
new Date().getFullYear() - 1900 + 3 + 1,
12 + 1,
31 + 1,
]);
Expand Down