Fixed support for "additionalProperties"#1085
Closed
EasyTuan wants to merge 1 commit intorjsf-team:masterfrom
EasyTuan:master
Closed
Fixed support for "additionalProperties"#1085EasyTuan wants to merge 1 commit intorjsf-team:masterfrom EasyTuan:master
EasyTuan wants to merge 1 commit intorjsf-team:masterfrom
EasyTuan:master
Conversation
edi9999
reviewed
Dec 4, 2018
| ); | ||
|
|
||
| expect(labels).eql(["baz", "bar", "qux", "foo"]); | ||
| expect(labels).eql([]); |
Collaborator
There was a problem hiding this comment.
You're probably added a bug if you change that test
edi9999
reviewed
Dec 4, 2018
| it("should render a label for the additional property key", () => { | ||
| const { node } = createFormComponent({ | ||
| schema, | ||
| formData: { first: 1 }, |
Collaborator
There was a problem hiding this comment.
tests should not be deleted except if the feature has been removed completely
Contributor
|
@EasyTuan hi, what's the status? Do you plan to keep on working on this PR? Can we help somehow? 😄 |
9 tasks
Contributor
|
Closing in favor of #1123. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Details
I fixed the bug of the original property 'additionalProperties' and can support the delete function to beautify the style.