Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module.require is not available in the browser #4

Closed
AdrianRossouw opened this issue Mar 3, 2015 · 2 comments
Closed

module.require is not available in the browser #4

AdrianRossouw opened this issue Mar 3, 2015 · 2 comments

Comments

@AdrianRossouw
Copy link

This means that all modules that depend on use-plugin are probably not portable to the browser environment until the implementation is rewritten to make use of the global require.

This is the relevant issue for browserify, and the issue for webpack.

There's an added wrinkle here in that browserify won't handle dynamic require statements, although webpack does try to do more in this regard.
AdrianRossouw added a commit to AdrianRossouw/seneca that referenced this issue Mar 3, 2015
@AdrianRossouw
process.exit doesn't work in the browser.
1c659c2 
This causes some tests to time out instead of kill seneca.

the [process shim](https://www.npmjs.com/package/process) only exists to provide the
nextTick method.

the ultimate reason is still
rjrodger/use-plugin#4
AdrianRossouw added a commit to AdrianRossouw/seneca that referenced this issue Mar 3, 2015
@AdrianRossouw
skip all tests that rely on use-plugin
031c82f 
all of these tests are broken by this issue in use-plugin:
rjrodger/use-plugin#4

once a viable fix is available, they should be enabled
one-by-one and tested again.
@AdrianRossouw AdrianRossouw mentioned this issue Mar 3, 2015
Closed
@AdrianRossouw
Copy link
Author

btw: I kind of suspect it might not be really possible to port this module to the browser completely, because it seems to depend on doing a lot of things at run-time, which need to be happening at build time via static analysis.

@rjrodger
Copy link
Owner

closing as obsoleted by https://github.com/voxgig/seneca-browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AdrianRossouw @rjrodger