Enable warnings as errors

[rjmurillo]

• Updated .editorconfig to set policy on some duplicate warnings for TODO. Borrowed from Add more analyzers and bump Meziantou.Analzer to latest version #89 to make merging easier
• Updated cases where nullability was incorrect (something could be passed as null but wasn't, something was marked as nullable but wasn't). Where possible added asserts so we can catch cases when they arise.
• Removed <NoWarn> from Moq.Analyzers.csproj
• Added <TreatWarningsAsErrors> and MSBuildTreatWarningsAsErrors elements to CodeAnalysis.props
  • Set each to true when MSBuild property $(ContinuousIntegrationBuild) is true from DotNet.ReproducibleBuilds package

[MattKotsenas]

Is there a way so that the rules the Codacity static analysis reports are driven by our .editorconfig? It's currently showing errors for stuff we've intentionally disabled (at least to date) like CLS attributes and copyright headers.

The point isn't that those rules are good or bad, it's that we've introduced multiple, conflicting sources-of-truth.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.35% (target: -1.00%)	❌ 90.48% (target: 95.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (9c4dde8)	400	371	92.75%
Head commit (db75e30)	406 (+6)	378 (+7)	93.10% (+0.35%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#91)	21	19	90.48%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

---

_{🚀 Don’t miss a bit, follow what’s new on Codacy.}

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[rjmurillo]

@MattKotsenas we can turn off Codacy when we get reporting of coverage up as something we can gate on. We can also check in a config file to keep the integration sane. I disabled the Sonar analyzer, so I'm really just interested in code coverage and some obvious linting things in YAML, PowerShell, and JSON files. The recommendation from Codacy is to check in the configuration for the tools used themselves and it'll pick them up.