CodeRabbit Generated Unit Tests: Add comprehensive test cases for MockBehavior.Loose and SyntaxGeneratorExtensions#704
Closed
coderabbitai[bot] wants to merge 1 commit intomainfrom
Closed
Conversation
…kBehavior.Loose and SyntaxGeneratorExtensions
Contributor
Author
|
Important Review skippedCodeRabbit bot authored PR detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
Comment on lines
+36
to
+53
| IEnumerable<object[]> mockConstructorsWithTargetTypedNew = new object[][] | ||
| { | ||
| [ | ||
| """Mock<ISample> mock = {|Moq1400:new()|};""", | ||
| """Mock<ISample> mock = new(MockBehavior.Loose);""", | ||
| ], | ||
| [ | ||
| """Mock<ISample> mock = {|Moq1400:new(MockBehavior.Default)|};""", | ||
| """Mock<ISample> mock = new(MockBehavior.Loose);""", | ||
| ], | ||
| [ | ||
| """Mock<ISample> mock = new(MockBehavior.Loose);""", | ||
| """Mock<ISample> mock = new(MockBehavior.Loose);""", | ||
| ], | ||
| [ | ||
| """Mock<ISample> mock = new(MockBehavior.Strict);""", | ||
| """Mock<ISample> mock = new(MockBehavior.Strict);""", | ||
| ], |
rjmurillo
requested changes
Aug 5, 2025
| } | ||
| """; | ||
|
|
||
| const string quickFix = """ |
Owner
There was a problem hiding this comment.
We can DRY these out and make them data driven 'theory'
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit tests for the SetExplicitMockBehaviorCodeFix analyzer to improve test coverage for various scenarios involving MockBehavior.Loose and different Mock construction patterns.
Key changes:
- Adds test coverage for target-typed new expressions with Mock constructors
- Adds 14 new test methods covering edge cases like nested constructors, field/property declarations, method parameters, and complex inheritance scenarios
- Extends the existing TestData() method to include target-typed new expression test cases
Comment on lines
+772
to
+774
| var mock1 = {|Moq1400:new Mock<Calculator>("test")|}; | ||
| var mock2 = {|Moq1400:new Mock<Calculator>("test", MockBehavior.Default)|}; | ||
| var mock3 = new Mock<Calculator>("test", MockBehavior.Strict); |
There was a problem hiding this comment.
The parameter order transformation is inconsistent. In the original code, mock1 has constructor parameters before behavior, but in the fixed code it's reordered to behavior first. However, mock3 maintains the original parameter order. This inconsistency suggests the code fix may not be handling parameter reordering correctly for all cases.
Comment on lines
+793
to
+795
| var mock1 = new Mock<Calculator>(MockBehavior.Loose, "test"); | ||
| var mock2 = new Mock<Calculator>(MockBehavior.Loose, "test"); | ||
| var mock3 = new Mock<Calculator>("test", MockBehavior.Strict); |
There was a problem hiding this comment.
The parameter order transformation is inconsistent. In the original code, mock1 has constructor parameters before behavior, but in the fixed code it's reordered to behavior first. However, mock3 maintains the original parameter order. This inconsistency suggests the code fix may not be handling parameter reordering correctly for all cases.
Suggested change
| var mock1 = new Mock<Calculator>(MockBehavior.Loose, "test"); | |
| var mock2 = new Mock<Calculator>(MockBehavior.Loose, "test"); | |
| var mock3 = new Mock<Calculator>("test", MockBehavior.Strict); | |
| var mock3 = new Mock<Calculator>(MockBehavior.Strict, "test"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit test generation was requested by @rjmurillo.
The following files were modified:
tests/Moq.Analyzers.Test/SetExplicitMockBehaviorCodeFixTests.cs