refactor: Update AsShouldBeUsedOnlyForInterfaceAnalyzer description and category by rjmurillo · Pull Request #669 · rjmurillo/moq.analyzers

rjmurillo · 2025-07-28T00:59:33Z

Update src/Analyzers/AsShouldBeUsedOnlyForInterfaceAnalyzer.cs to use proper messaging and category

Fixes #648

Summary by CodeRabbit

New Features
- Added a new analyzer rule (Moq1300) to enforce correct usage of As<T>() with interfaces only, providing detailed error messages and documentation links.
Bug Fixes
- Improved diagnostic messages to specify the non-interface type used with As<T>().
Documentation
- Updated documentation for Moq1300 with category and code fix information.
- Simplified task list formatting in issue templates.
- Expanded contributor guidelines for task processing and error handling.
- Clarified analyzer release documentation protocols.
Chores
- Streamlined Codacy configuration by reducing supported runtimes and analysis tools.

- Updates diagnostic message and description for clarity - Corrects the diagnostic category to Moq Fixes #648

…instructions - Added a new rule to load `./.github/copilot-instructions.md` and `./.github/instructions/README.md` before starting any work on sub-tasks.

coderabbitai · 2025-07-28T00:59:42Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between b3f4063 and d13fda2.

📒 Files selected for processing (1)

src/Analyzers/AnalyzerReleases.Unshipped.md (1 hunks)

 _____________________
< Git gud or git out. >
 ---------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

📝 Walkthrough

Walkthrough

This change updates analyzer metadata and documentation for the AsShouldBeUsedOnlyForInterfaceAnalyzer. It revises the diagnostic message to include the type name, moves the original message to the description, and changes the category to "Usage". Associated documentation, release notes, and configuration files are updated for consistency. Additional rules and clarifications are added to contributor instructions and process documentation.

Changes

Cohort / Files	Change Summary
Analyzer logic & metadata: src/Analyzers/AsShouldBeUsedOnlyForInterfaceAnalyzer.cs src/Common/DiagnosticCategory.cs	Diagnostic message updated to include type name; message moved to description; category changed to "Usage"; new constant added.
Analyzer release notes: src/Analyzers/AnalyzerReleases.Unshipped.md	Moq1300 rule reclassified: category set to "Usage", severity to "Error", note added.
Rule documentation: docs/rules/Moq1300.md	Added "Category: Usage" to summary; changed "CodeFix" value from "False" to "No".
Contributor instructions: .github/copilot-instructions.md	Added rules for handling build failures and prohibiting changes to `AnalyzerReleases.Shipped.md`.
Process documentation: .cursor/rules/process-task-list.md	Expanded with rules for loading instructions, handling build/test failures, and revised PR completion protocol.
Task list documentation: .cursor/rules/generate-tasks.md	Checklist item format simplified to reference only issue numbers (e.g., `- [ ] #456`).
Codacy configuration: .codacy/codacy.yaml	Removed Dart, Go, Java, Node runtimes and related tools; retained only Python and selected analysis tools.
Codacy usage rules: .cursor/rules/codacy.mdc	Removed rules about fixed parameter values and unnecessary `git remote -v` calls.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Analyzer
    participant DiagnosticCategory

    User->>Analyzer: Calls As<T>() with non-interface type
    Analyzer->>DiagnosticCategory: Uses Usage category
    Analyzer->>Analyzer: Checks if T is interface
    alt T is not interface
        Analyzer->>User: Reports diagnostic "Type '{T}' is not an interface"
    end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Update copilot instructions for PR checks and CI #552: Both PRs modify .github/copilot-instructions.md to update contributor guidelines, though the focus of the changes differs.
Strengthen Copilot instructions #426: Related updates to .github/copilot-instructions.md improving developer guidance.
Add rule suppression docs to README and each rule #241: Enhancements to Moq1300 rule documentation and formatting.

Suggested reviewers

MattKotsenas

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch refactor/issue-648

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

rjmurillo · 2025-07-28T00:59:54Z

Reviewer note: I'm A/B against #668

codacy-production · 2025-07-28T01:03:17Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.02% (target: -1.00%)	✅ 100.00% (target: 95.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`1d5a6d0`)	1830	1635	89.34%
Head commit (`d13fda2`)	1834 (+4)	1639 (+4)	89.37% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#669)	8	8	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

- Adds 'Usage' to DiagnosticCategory - Updates AsShouldBeUsedOnlyForInterfaceAnalyzer to use 'Usage' category - Updates shipped and unshipped release files Fixes #648

- Added a new rule to treat build and test failures as critical stop conditions, emphasizing the need to diagnose and fix issues before proceeding with tasks. - Updated the task list management documentation to ensure clarity on handling build failures and the importance of following the completion protocol.

…ion process - Enhanced the task implementation section to include a new step for user verification before marking tasks as completed. - Added guidance on how to format commit messages, emphasizing the use of the convention commit format and the importance of descriptive bodies that reference related tasks. This update aims to improve clarity in task management and ensure proper communication of changes made.

- Added a critical note emphasizing that `AnalyzerReleases.Shipped.md` is immutable and should not be modified. - All changes to existing rules, including category or severity updates, must be documented in `AnalyzerReleases.Unshipped.md`. This update aims to ensure proper documentation practices and maintain the integrity of release records.

- Changed the category of Moq1300 from 'Usage' to 'Moq' in AnalyzerReleases.Shipped.md. - Added a new section for changed rules in AnalyzerReleases.Unshipped.md to document the update. This update ensures accurate categorization and clarity in the release notes.

coderabbitai

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d5a6d0 and b3f4063.

📒 Files selected for processing (9)

.codacy/codacy.yaml (0 hunks)
.cursor/rules/codacy.mdc (0 hunks)
.cursor/rules/generate-tasks.md (2 hunks)
.cursor/rules/process-task-list.md (2 hunks)
.github/copilot-instructions.md (2 hunks)
docs/rules/Moq1300.md (1 hunks)
src/Analyzers/AnalyzerReleases.Unshipped.md (1 hunks)
src/Analyzers/AsShouldBeUsedOnlyForInterfaceAnalyzer.cs (3 hunks)
src/Common/DiagnosticCategory.cs (1 hunks)

💤 Files with no reviewable changes (2)

.codacy/codacy.yaml
.cursor/rules/codacy.mdc

🧰 Additional context used

📓 Path-based instructions (10)

{docs/rules/**,README.md}

📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)

{docs/rules/**,README.md}: Update docs/rules/ and README.md for any analyzer, code fix, or workflow change
Update docs/rules/ and README.md if you add or change any analyzer, code fix, or workflow
Always update documentation for new features, API changes, or workflow/process changes

Files:

docs/rules/Moq1300.md

{src/Analyzers/AnalyzerReleases.Unshipped.md,docs/rules/**}

📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)

Update src/Analyzers/AnalyzerReleases.Unshipped.md and add or update documentation in docs/rules/ for each diagnostic

Files:

docs/rules/Moq1300.md
src/Analyzers/AnalyzerReleases.Unshipped.md

**/*.md

📄 CodeRabbit Inference Engine (CONTRIBUTING.md)

All documentation and markdown reports must pass formatting checks. Use a markdown linter if available.

Files:

docs/rules/Moq1300.md
src/Analyzers/AnalyzerReleases.Unshipped.md

docs/rules/**/*.md

📄 CodeRabbit Inference Engine (CONTRIBUTING.md)

Update 'docs/rules/' for analyzer changes.

Files:

docs/rules/Moq1300.md

⚙️ CodeRabbit Configuration File

Evaluate the markdown files against the standards for Roslyn Code Analysis rules

Files:

docs/rules/Moq1300.md

src/Analyzers/AnalyzerReleases.Unshipped.md

📄 CodeRabbit Inference Engine (CONTRIBUTING.md)

Update 'src/Analyzers/AnalyzerReleases.Unshipped.md' for release notes.

Files:

src/Analyzers/AnalyzerReleases.Unshipped.md

**/*.cs

📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)

Do not add or duplicate usings covered by src/Common/GlobalUsings.cs

**/*.cs: Add XML documentation for all public APIs.
Use tags for all type references in XML documentation instead of plain text.
Use for C# keywords in XML documentation.
Use for parameter references in XML documentation.
Use .. for inline code snippets in XML documentation.
All public APIs must have complete XML documentation with accurate and up-to-date information.

Files:

src/Analyzers/AsShouldBeUsedOnlyForInterfaceAnalyzer.cs
src/Common/DiagnosticCategory.cs

⚙️ CodeRabbit Configuration File

**/*.cs: I need your help tracking down and fixing some bugs that have been reported in this codebase.

I suspect the bugs are related to:

Incorrect handling of edge cases

Off-by-one errors in loops or array indexing

Unexpected data types

Uncaught exceptions

Concurrency issues

Improper configuration settings

To diagnose:

Review the code carefully and systematically

Trace the relevant code paths

Consider boundary conditions and potential error states

Look for antipatterns that tend to cause bugs

Run the code mentally with example inputs

Think about interactions between components

When you find potential bugs, for each one provide:

File path and line number(s)

Description of the issue and why it's a bug

Example input that would trigger the bug

Suggestions for how to fix it

After analysis, please update the code with your proposed fixes. Try to match the existing code style. Add regression tests if possible to prevent the bugs from recurring.

I appreciate your diligence and attention to detail! Let me know if you need any clarification on the intended behavior of the code.

Files:

src/Analyzers/AsShouldBeUsedOnlyForInterfaceAnalyzer.cs
src/Common/DiagnosticCategory.cs

{src/Analyzers/*Analyzer.cs,src/CodeFixes/*Fixer.cs,tests/Moq.Analyzers.Test/*AnalyzerTests.cs,tests/Moq.Analyzers.Test/*CodeFixTests.cs}

📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)

Use [Description]Analyzer.cs, [Description]Fixer.cs, [Description]AnalyzerTests.cs, [Description]CodeFixTests.cs for new components

Files:

src/Analyzers/AsShouldBeUsedOnlyForInterfaceAnalyzer.cs

{src/Analyzers/**/*.cs,src/CodeFixes/**/*.cs,src/Common/**/*.cs}

📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)

Place new analyzers in src/Analyzers/, code fixes in src/CodeFixes/, and shared logic in src/Common/

Files:

src/Analyzers/AsShouldBeUsedOnlyForInterfaceAnalyzer.cs
src/Common/DiagnosticCategory.cs

**/*.{cs,csproj,sln}

📄 CodeRabbit Inference Engine (CONTRIBUTING.md)

Build with 'dotnet build /p:PedanticMode=true'. All warnings must be treated as errors. PRs that do not build cleanly will be closed.

Files:

src/Analyzers/AsShouldBeUsedOnlyForInterfaceAnalyzer.cs
src/Common/DiagnosticCategory.cs

src/**/*.cs

📄 CodeRabbit Inference Engine (CONTRIBUTING.md)

All diagnostic spans in Roslyn analyzers MUST be character-precise. A test failure related to a diagnostic span is a CRITICAL FAILURE and must be addressed immediately.

Files:

src/Analyzers/AsShouldBeUsedOnlyForInterfaceAnalyzer.cs
src/Common/DiagnosticCategory.cs

🧠 Learnings (8)

📓 Common learnings

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.110Z
Learning: Reference affected analyzer rule IDs in PR descriptions.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: If your PR changes or adds analyzer tests, include a note in the PR description about which Moq versions are targeted and how test data is grouped accordingly.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to {src/Analyzers/*Analyzer.cs,src/CodeFixes/*Fixer.cs,tests/Moq.Analyzers.Test/*AnalyzerTests.cs,tests/Moq.Analyzers.Test/*CodeFixTests.cs} : Use [Description]Analyzer.cs, [Description]Fixer.cs, [Description]AnalyzerTests.cs, [Description]CodeFixTests.cs for new components

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.110Z
Learning: Summarize all changes in the PR description and cite relevant lines from modified files for clarity.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: Applies to src/Analyzers/AnalyzerReleases.Unshipped.md : Update 'src/Analyzers/AnalyzerReleases.Unshipped.md' for release notes.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to tests/Moq.Analyzers.Test/**/*.cs : Add or update unit tests in tests/Moq.Analyzers.Test/ for every analyzer or code fix change

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: Applies to tests/Moq.Analyzers.Benchmarks/**/*.cs : Performance-sensitive changes require benchmark validation. Run performance tests locally before submitting PRs and include performance regression analysis in PR description.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.111Z
Learning: Use [Description]Analyzer.cs, [Description]Fixer.cs, [Description]AnalyzerTests.cs, [Description]CodeFixTests.cs for new components.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: Applies to **/*.{cs} : Run Codacy CLI analysis on all changed files and fix all reported issues before submitting the PR.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to {src/Analyzers/AnalyzerReleases.Unshipped.md,docs/rules/**} : Update src/Analyzers/AnalyzerReleases.Unshipped.md and add or update documentation in docs/rules/ for each diagnostic

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.110Z
Learning: If changing an analyzer, update documentation in 'docs/rules' to reflect all changes.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.110Z
Learning: If adding an analyzer, also add a code fix, a benchmark, and documentation in 'docs/rules'.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: Applies to docs/rules/**/*.md : Update 'docs/rules/' for analyzer changes.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to {docs/rules/**,README.md} : Update docs/rules/ and README.md for any analyzer, code fix, or workflow change

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to {docs/rules/**,README.md} : Update docs/rules/ and README.md if you add or change any analyzer, code fix, or workflow

docs/rules/Moq1300.md (19)

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: Applies to tests/**/*.cs : In code fix tests, the code that triggers the analyzer MUST be wrapped with the diagnostic marker syntax (e.g., {|Moq1210:...|}).

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to tests/Moq.Analyzers.Test/**/*.cs : Add or update unit tests in tests/Moq.Analyzers.Test/ for every analyzer or code fix change

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: If your PR changes or adds analyzer tests, include a note in the PR description about which Moq versions are targeted and how test data is grouped accordingly.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: Applies to tests/Moq.Analyzers.Benchmarks/**/*.cs : Performance-sensitive changes require benchmark validation. Run performance tests locally before submitting PRs and include performance regression analysis in PR description.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.111Z
Learning: If a Moq feature has known limitations or edge cases (e.g., explicit interface implementation, event setup), document this in the test or analyzer code.

Learnt from: rjmurillo
PR: rjmurillo/moq.analyzers#0
File: :0-0
Timestamp: 2025-07-22T08:42:51.055Z
Learning: For the moq.analyzers repository, diagnostic IDs follow specific ranges: Moq1000-1099 (Usage), Moq1100-1199 (Correctness), Moq1200-1299 (Correctness), Moq1300-1399 (Usage), Moq1400-1499 (Best Practice), Moq1500-1599 (Best Practice), Moq1600-1999 (Reserved). No analyzers exist above 1600.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to {src/Analyzers/*Analyzer.cs,src/CodeFixes/*Fixer.cs,tests/Moq.Analyzers.Test/*AnalyzerTests.cs,tests/Moq.Analyzers.Test/*CodeFixTests.cs} : Use [Description]Analyzer.cs, [Description]Fixer.cs, [Description]AnalyzerTests.cs, [Description]CodeFixTests.cs for new components

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Note Moq version compatibility for analyzer/test changes

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.110Z
Learning: Do not include tests for features/APIs that do not exist in the targeted Moq version.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: Applies to tests/**/*.cs : Do not include tests for APIs or patterns that do not exist in the targeted Moq version; such tests will fail at compile time.

Learnt from: rjmurillo
PR: rjmurillo/moq.analyzers#0
File: :0-0
Timestamp: 2025-07-22T17:25:24.857Z
Learning: Applies to {src/Analyzers//*.cs,tests//*.cs}: For Moq protected member setups using string-based overloads (e.g., mock.Protected().Setup("MethodName", ...)), use ItExpr matchers instead of It matchers. When using As<T>() interface mapping, regular It matchers are allowed in lambda expressions.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.111Z
Learning: Setups for explicit interface implementations must use the correct cast syntax (e.g., ((IMyInterface)x).Method()), and only test these scenarios if the Moq version supports them.

Learnt from: rjmurillo
PR: rjmurillo/moq.analyzers#0
File: :0-0
Timestamp: 2025-07-22T17:25:24.857Z
Learning: Applies to {src/Analyzers//*.cs,tests//*.cs}: Moq protected member APIs that need analyzer validation include: Setup, SetupSequence, SetupGet, SetupSet, Verify, VerifyGet, VerifySet, and As() for interface mapping. All protected members must be virtual or abstract to be mockable.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to tests/Moq.Analyzers.Test/*CodeFixTests.cs : Use the [MemberData]-annotated [Theory] pattern with a public static IEnumerable<object[]> data source for code fix tests

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: Applies to tests/**/*.cs : Setups for explicit interface implementations must use the correct cast syntax (e.g., ((IMyInterface)x).Method()).

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.110Z
Learning: Group test data by Moq version compatibility: 'new' for Moq 4.18.4+, 'both' or 'old' for features available in both 4.8.2 and 4.18.4.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.111Z
Learning: When testing code fixes that modify a class member, use a data-driven pattern: a public static IEnumerable<object[]> data source, a [Theory] test method with [MemberData], a static Template function with placeholders, and Verify.VerifyCodeFixAsync.

.github/copilot-instructions.md (25)

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to {src/Analyzers/AnalyzerReleases.Unshipped.md,docs/rules/**} : Update src/Analyzers/AnalyzerReleases.Unshipped.md and add or update documentation in docs/rules/ for each diagnostic

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .cursor/rules/csharp.mdc:0-0
Timestamp: 2025-07-19T08:09:48.255Z
Learning: Applies to *.{cs,csproj,sln} : Always read and apply the instructions in copilot-instructions.md when working on C# source or project files

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.111Z
Learning: Always check for and follow any new rules in .cursor/rules/, .editorconfig, and .github/copilot-instructions.md before making changes.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .windsurf/rules/csharp.md:0-0
Timestamp: 2025-07-22T02:59:43.736Z
Learning: Applies to *.{cs,csproj,sln} : Always read and apply the instructions in copilot-instructions.md when working on C# source or project files

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to {docs/rules/**,README.md} : Update docs/rules/ and README.md for any analyzer, code fix, or workflow change

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: Applies to docs/rules/**/*.md : Update 'docs/rules/' for analyzer changes.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: Applies to src/Analyzers/AnalyzerReleases.Unshipped.md : Update 'src/Analyzers/AnalyzerReleases.Unshipped.md' for release notes.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to {docs/rules/**,README.md} : Update docs/rules/ and README.md if you add or change any analyzer, code fix, or workflow

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.110Z
Learning: Reference affected analyzer rule IDs in PR descriptions.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to {docs/rules/**,README.md} : Always update documentation for new features, API changes, or workflow/process changes

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: Never guess which Roslyn API to use. If you are not 100% certain, consult existing, working analyzers in the 'src/' directory.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.111Z
Learning: Never guess which Roslyn API to use; consult existing, working analyzers in src/ if unsure.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: Before working on Roslyn analyzers, you must have expert-level understanding of Roslyn syntax tree navigation, diagnostic span calculation, IOperation vs ISyntaxNode analysis, CodeFixProvider and DocumentEditor patterns, and Moq framework semantics.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.111Z
Learning: When creating a new Roslyn analyzer or code fix, locate an existing, similar component within the src/ directory and replicate its structure, dependency injection, and overall design. Prefer the IOperation-based approach where applicable.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.111Z
Learning: If you cannot truthfully declare expert-level Roslyn knowledge, you must stop and request guidance.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.111Z
Learning: Do not 'fix' a failing test by adjusting code and re-running; fixes must come from a deliberate, correct understanding of the syntax tree.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-07-27T02:45:02.136Z
Learning: Applies to src/**/*.cs : All diagnostic spans in Roslyn analyzers MUST be character-precise. A test failure related to a diagnostic span is a CRITICAL FAILURE and must be addressed immediately.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.111Z
Learning: For Roslyn analyzer development: diagnostic spans must be character-precise; a test failure related to a diagnostic span is a critical failure and requires re-evaluation.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.111Z
Learning: Before implementing an analyzer, verify you can trace the syntax tree path from mock.Verify() to the member access, understand Roslyn expression types, diagnostic span requirements, and when to use IOperation vs ISyntaxNode.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Never copy-and-tweak analyzer patterns. Re-read the requirements before you start.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to {src/Analyzers//*.cs,src/CodeFixes//.cs,src/Common/**/.cs} : Place new analyzers in src/Analyzers/, code fixes in src/CodeFixes/, and shared logic in src/Common/

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to tests/Moq.Analyzers.Test/**/*.cs : Add or update unit tests in tests/Moq.Analyzers.Test/ for every analyzer or code fix change

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-27T02:44:39.596Z
Learning: Applies to {src/Analyzers/*Analyzer.cs,src/CodeFixes/*Fixer.cs,tests/Moq.Analyzers.Test/*AnalyzerTests.cs,tests/Moq.Analyzers.Test/*CodeFixTests.cs} : Use [Description]Analyzer.cs, [Description]Fixer.cs, [Description]AnalyzerTests.cs, [Description]CodeFixTests.cs for new components

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.111Z
Learning: When making changes, follow the workflow: Edit/Add Code or Test → Run codacy_cli_analyze → Fix issues if any → Run/Update Tests → Fix test failures if any → Update Docs → Commit & PR.

Learnt from: CR
PR: rjmurillo/moq.analyzers#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-25T12:42:47.110Z
Learning: If adding an analyzer, also add a code fix, a benchmark, and documentation in 'docs/rules'.

src/Analyzers/AnalyzerReleases.Unshipped.md (16)