-
Notifications
You must be signed in to change notification settings - Fork 4
Update copilot instructions for PR checks and CI #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4d49d77
Add support for delegate constructor callbacks
Copilot 3674eef
Changes before error encountered
Copilot 6a13402
Fix delegate constructor callback detection for ref/out parameters
Copilot 50735ca
Address code review feedback: add curly braces and update documentation
Copilot 513b374
Address code review feedback: remove unnecessary using and consolidat…
Copilot b2ada4c
Apply suggestions from code review
rjmurillo 5d9348b
Improve documentation and code style for callback parameter validation
Copilot 48140bb
Identify root cause of ref/out parameter validation issue
Copilot 02bc9e4
Merge from main
rjmurillo f42db6c
Merge branch 'main' into copilot/fix-500
rjmurillo 6a19e9a
fix: improve ref/out/in parameter validation in callback analyzer
rjmurillo 0ac5afb
docs: add explicit PR checks and CI requirements to Copilot instructions
rjmurillo 43b847b
Merge branch 'main' into copilot/fix-500
rjmurillo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -6,6 +6,38 @@ You are an experienced .NET developer working on Roslyn analyzers for the Moq fr | |||||||||||
|
|
||||||||||||
| --- | ||||||||||||
|
|
||||||||||||
| ## PR Checks & CI Requirements | ||||||||||||
|
|
||||||||||||
| **Every pull request must pass these checks before review:** | ||||||||||||
|
|
||||||||||||
| - **Formatting:** | ||||||||||||
| Run `dotnet format` and commit all changes. PRs with formatting issues will be rejected. | ||||||||||||
| - **Build:** | ||||||||||||
| Build with `dotnet build /p:PedanticMode=true`. All warnings must be treated as errors. PRs that do not build cleanly will be closed. | ||||||||||||
| - **Tests:** | ||||||||||||
| Run all unit tests: | ||||||||||||
| `dotnet test --settings ./build/targets/tests/test.runsettings` | ||||||||||||
| All tests must pass. PRs with failing tests will be closed. | ||||||||||||
| - **Codacy Analysis:** | ||||||||||||
| Run Codacy CLI analysis on all changed files. Fix all reported issues before submitting the PR. | ||||||||||||
| - **Evidence Required:** | ||||||||||||
| PR description must include console output or screenshots for: | ||||||||||||
| - `dotnet format` | ||||||||||||
| - `dotnet build` | ||||||||||||
| - `dotnet test` | ||||||||||||
| - Codacy analysis (if issues were found and fixed) | ||||||||||||
| - **No Received Files:** | ||||||||||||
| Remove any `*.received.*` files before committing. | ||||||||||||
| - **Moq Version Awareness:** | ||||||||||||
| If tests are added/changed, specify which Moq versions are targeted and how test data is grouped. | ||||||||||||
|
||||||||||||
| If tests are added/changed, specify which Moq versions are targeted and how test data is grouped. | |
| If tests are added/changed, document the following in the PR description: | |
| - The specific Moq version(s) targeted by the tests. | |
| - A brief explanation of how test data is grouped, including the rationale for the grouping strategy. | |
| Ensure this information is clear and concise to assist reviewers in understanding the changes. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Codacy Analysis section lacks specific instructions on how to run the CLI analysis. Consider adding the exact command or referencing where developers can find the instructions.