Skip to content

Fix BuildCheck property initialization timing issues (BC0202 errors) #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjmurillo merged 2 commits into from
Jun 7, 2025
Merged

Fix BuildCheck property initialization timing issues (BC0202 errors) #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a68e7e9
Fix BuildCheck property initialization timing issues
Copilot Jun 7, 2025
543ca2b
Address PR feedback: fix property label and remove duplication
Copilot Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
<RepoRoot>$(MSBuildThisFileDirectory)</RepoRoot>
</PropertyGroup>

<!-- Properties that need to be available early for NuGet pack targets -->
<PropertyGroup Condition="'$(MSBuildProjectName)' == 'Moq.Analyzers'">
<Description>Roslyn analyzer that helps to write unit tests using Moq mocking library by highlighting typical errors and suggesting quick fixes. Port of Resharper extension to Roslyn. Find the full list of detected issues at project GitHub page.</Description>
Comment thread
rjmurillo marked this conversation as resolved.
</PropertyGroup>


<Import Project="build/targets/artifacts/Artifacts.props" />
<Import Project="build/targets/compiler/Compiler.props" />
<Import Project="build/targets/reproducible/Reproducible.props" />
Expand Down
6 changes: 4 additions & 2 deletions src/Analyzers/Moq.Analyzers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
</PropertyGroup>

<PropertyGroup>
<RootNamespace>Moq.Analyzers</RootNamespace>
<AssemblyName>Moq.Analyzers</AssemblyName>
<TargetFramework>netstandard2.0</TargetFramework>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<IncludeBuildOutput>false</IncludeBuildOutput><!-- Don't place the output assembly in the package's lib/ folder -->
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking><!-- Don't add the TargetFramework as a package dependency -->
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies><!-- Because we're a compiler plugin, we need to bundle any dependencies into our package -->
Expand All @@ -16,7 +19,6 @@
<PackageProjectUrl>https://github.com/rjmurillo/moq.analyzers</PackageProjectUrl>
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
<PackageReadmeFile>README.md</PackageReadmeFile>
<Description>Roslyn analyzer that helps to write unit tests using Moq mocking library by highlighting typical errors and suggesting quick fixes. Port of Resharper extension to Roslyn. Find the full list of detected issues at project GitHub page.</Description>
<PackageReleaseNotes>A changelog is available at https://github.com/rjmurillo/moq.analyzers/releases</PackageReleaseNotes>
<Copyright>2017 Andrey Lipatkin</Copyright>
<PackageTags>moq, tdd, mocking, mocks, unittesting, agile, unittest, mock, test, analyzers</PackageTags>
Expand Down
9 changes: 4 additions & 5 deletions src/Common/Common.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup Label="Shared project settings">
<ShowCommonFiles>true</ShowCommonFiles>
<EnableDefaultItems>false</EnableDefaultItems><!-- Disable default behavior so we rely on the included props -->
</PropertyGroup>

<!--
NOTE: This project is not intended to be referenced directly. The common components should instead be compiled
Expand All @@ -22,11 +26,6 @@
<SquiggleCop_Enabled>false</SquiggleCop_Enabled>
</PropertyGroup>

<PropertyGroup Label="Shared project settings">
<!-- Disable default behavior so we rely on the included props -->
<EnableDefaultItems>false</EnableDefaultItems>
<ShowCommonFiles>true</ShowCommonFiles>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" PrivateAssets="all" />
Expand Down
3 changes: 3 additions & 0 deletions src/Common/Common.projitems
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<Project>
<PropertyGroup>
Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected an indentation at 4 instead of at 2.

<ShowCommonFiles Condition="'$(ShowCommonFiles)' == ''">false</ShowCommonFiles>
</PropertyGroup>
Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected an indentation at 4 instead of at 2.

<ItemGroup>
<Compile Include="$(MSBuildThisFileDirectory)/**/*.cs" Visible=" '$(ShowCommonFiles)' == 'true' " />
</ItemGroup>
Expand Down