Optimize DefaultIfNotSingle loop by rjmurillo · Pull Request #430 · rjmurillo/moq.analyzers

Add benchmarks for DefaultIfNotSingle variants

rjmurillo

committed

Fix: Ensure DefaultIfNotSingle optimizations and tests pass all local checks, format, and build. Verified against copilot-instructions.md workflow.

rjmurillo

committed

Add null checks to DefaultIfNotSingleOptimizedMethod using ArgumentNullException.ThrowIfNull for source and predicate

rjmurillo

committed

Rebaseline SquiggleCop

rjmurillo

committed

Use ArgumentNullException.ThrowIfNull for parameter validation in DefaultIfNotSingleBaselineMethod

rjmurillo

committed

Revert to classic null-check pattern in DefaultIfNotSingle extension methods for compatibility

rjmurillo

committed

Update SquiggleCop.Baseline.yaml to set IsEverSuppressed to true for IDE0005, indicating that the unnecessary using directive warning can be suppressed.

rjmurillo

committed

Add tests to cover ArgumentNullException for null source and predicate in DefaultIfNotSingle extension methods

rjmurillo

committed

fix(test): reset CountingEnumerable<T>.Count at start of each enumeration to prevent accumulation across enumerations

rjmurillo

committed

test: add missing usings and use explicit types to fix ECS0900 and formatting issues in EnumerableExtensionsTests

rjmurillo

committed

test: use int? and Assert.Null for DefaultIfNotSingle results to fix ECS0900 boxing/unboxing errors

rjmurillo

committed

test: add ECS0900-compliant string-based tests for DefaultIfNotSingle null predicate; comment out int-based tests that trigger boxing/unboxing

rjmurillo

committed

test: remove int-based DefaultIfNotSingle null predicate tests to resolve ECS0900 and style errors; use string-based tests for coverage

rjmurillo

committed

test: remove int-based null source test for DefaultIfNotSingle to resolve ECS0900; string-based tests provide equivalent coverage

rjmurillo

committed

test: expect 0 (default int) instead of null for DefaultIfNotSingle<int> results to match implementation

rjmurillo

committed

test: update DefaultIfNotSingle test to expect null for empty object source, aligning with method behavior

rjmurillo

committed

chore: update SquiggleCop.Baseline.yaml and test baseline to change EffectiveSeverities from Error to Warning for multiple rules, ensuring consistency across analyzers and tests

rjmurillo

committed

test: add CountingEnumerable_Count test to verify Count resets on each enumeration, ensuring expected behavior

rjmurillo

committed

chore: update SquiggleCop.Baseline.yaml and test baseline to change EffectiveSeverities from Warning to Error for multiple rules, ensuring stricter enforcement of coding standards

rjmurillo

committed

refactor: extract argument validation into a separate method for DefaultIfNotSingle, improving code readability and maintainability

rjmurillo

committed

Update tests/Moq.Analyzers.Test/SquiggleCop.Baseline.yaml

rjmurillo

and

coderabbitai[bot]

authored

Resolve merge: accept deletion of SquiggleCop.Baseline.yaml files as in main

rjmurillo

committed

Merge branch 'codex/refactor-loop-to-replace-where-predicate' of https://github.com/rjmurillo/moq.analyzers into codex/refactor-loop-to-replace-where-predicate

rjmurillo

committed

test: add tests for DefaultIfNotSingle method to verify behavior with null sources and predicates, and ensure correct enumeration count resets in CountingEnumerable

rjmurillo

committed

test: cover early returns in SetStrictMockBehaviorFixer.RegisterCodeFixesAsync (TryGetEditProperties false, nodeToFix null)

rjmurillo

committed

test: add DiagnosticEditPropertiesTests to cover all branches and edge cases

rjmurillo

committed

refactor: remove untestable early return tests from SetExplicitMockBehavior and SetStrictMockBehavior code fix tests

rjmurillo

committed

test: enhance DefaultIfNotSingle tests to assert parameter name in ArgumentNullException for null predicate

rjmurillo

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize DefaultIfNotSingle loop#430

Optimize DefaultIfNotSingle loop#430
rjmurillo merged 30 commits intomainfrom
codex/refactor-loop-to-replace-where-predicate

Commits on Jun 8, 2025

Add benchmarks for DefaultIfNotSingle variants

Fix: Ensure DefaultIfNotSingle optimizations and tests pass all local checks, format, and build. Verified against copilot-instructions.md workflow.

Add null checks to DefaultIfNotSingleOptimizedMethod using ArgumentNullException.ThrowIfNull for source and predicate

Rebaseline SquiggleCop

Use ArgumentNullException.ThrowIfNull for parameter validation in DefaultIfNotSingleBaselineMethod

Revert to classic null-check pattern in DefaultIfNotSingle extension methods for compatibility

Update SquiggleCop.Baseline.yaml to set IsEverSuppressed to true for IDE0005, indicating that the unnecessary using directive warning can be suppressed.

Add tests to cover ArgumentNullException for null source and predicate in DefaultIfNotSingle extension methods

fix(test): reset CountingEnumerable<T>.Count at start of each enumeration to prevent accumulation across enumerations

test: add missing usings and use explicit types to fix ECS0900 and formatting issues in EnumerableExtensionsTests

test: use int? and Assert.Null for DefaultIfNotSingle results to fix ECS0900 boxing/unboxing errors

test: add ECS0900-compliant string-based tests for DefaultIfNotSingle null predicate; comment out int-based tests that trigger boxing/unboxing

test: remove int-based DefaultIfNotSingle null predicate tests to resolve ECS0900 and style errors; use string-based tests for coverage

test: remove int-based null source test for DefaultIfNotSingle to resolve ECS0900; string-based tests provide equivalent coverage

test: expect 0 (default int) instead of null for DefaultIfNotSingle<int> results to match implementation

test: update DefaultIfNotSingle test to expect null for empty object source, aligning with method behavior

chore: update SquiggleCop.Baseline.yaml and test baseline to change EffectiveSeverities from Error to Warning for multiple rules, ensuring consistency across analyzers and tests

test: add CountingEnumerable_Count test to verify Count resets on each enumeration, ensuring expected behavior

chore: update SquiggleCop.Baseline.yaml and test baseline to change EffectiveSeverities from Warning to Error for multiple rules, ensuring stricter enforcement of coding standards

refactor: extract argument validation into a separate method for DefaultIfNotSingle, improving code readability and maintainability

Update tests/Moq.Analyzers.Test/SquiggleCop.Baseline.yaml

Resolve merge: accept deletion of SquiggleCop.Baseline.yaml files as in main

Merge branch 'codex/refactor-loop-to-replace-where-predicate' of https://github.com/rjmurillo/moq.analyzers into codex/refactor-loop-to-replace-where-predicate

test: add tests for DefaultIfNotSingle method to verify behavior with null sources and predicates, and ensure correct enumeration count resets in CountingEnumerable

test: cover early returns in SetStrictMockBehaviorFixer.RegisterCodeFixesAsync (TryGetEditProperties false, nodeToFix null)

test: add DiagnosticEditPropertiesTests to cover all branches and edge cases

refactor: remove untestable early return tests from SetExplicitMockBehavior and SetStrictMockBehavior code fix tests

test: enhance DefaultIfNotSingle tests to assert parameter name in ArgumentNullException for null predicate

Commits on Jun 9, 2025

Merge branch 'main' into codex/refactor-loop-to-replace-where-predicate

Merge branch 'main' into codex/refactor-loop-to-replace-where-predicate