Skip to content

Add ValueTask detection tests #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjmurillo merged 5 commits into from
Jun 7, 2025
Merged

Add ValueTask detection tests #408

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
026e564
test: verify ValueTask task detection
rjmurillo May 31, 2025
df8b786
Update repository guidelines and package versions
rjmurillo Jun 1, 2025
9f8340f
Merge branch 'main' into codex/locate-and-fix-important-bug
rjmurillo Jun 1, 2025
6da8a7a
Merge branch 'main' into codex/locate-and-fix-important-bug
rjmurillo Jun 4, 2025
ac0d3ce
Merge branch 'main' into codex/locate-and-fix-important-bug
rjmurillo Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/Moq.Analyzers.Test/SetupShouldNotIncludeAsyncResultAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ public static IEnumerable<object[]> TestData()
IEnumerable<object[]> oldMoqSpecific = new object[][]
{
["""new Mock<AsyncClient>().Setup(c => {|Moq1201:c.GenericTaskAsync().Result|});"""],

["""new Mock<AsyncClient>().Setup(c => {|Moq1201:c.GenericValueTaskAsync().Result|});"""],
}.WithNamespaces().WithOldMoqReferenceAssemblyGroups();

// New Moq specific: Task<T>.Result should NOT produce diagnostic
Expand All @@ -41,6 +43,10 @@ public class AsyncClient
public virtual Task TaskAsync() => Task.CompletedTask;

public virtual Task<string> GenericTaskAsync() => Task.FromResult(string.Empty);

public virtual ValueTask ValueTaskAsync() => ValueTask.CompletedTask;

public virtual ValueTask<string> GenericValueTaskAsync() => ValueTask.FromResult(string.Empty);
}

internal class UnitTest
Expand Down