Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cons/dietline: remove some static variables #4218

Merged
merged 1 commit into from
Feb 13, 2024
Merged

cons/dietline: remove some static variables #4218

merged 1 commit into from
Feb 13, 2024

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Feb 13, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Remove global state - mutable statics.

Test plan

  • CI is green
  • Forward and reverse search works as before

Closing issues

Partially addresses #4055

wargio
wargio approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but damn.

@XVilka XVilka merged commit fa455f8 into dev Feb 13, 2024
47 checks passed
@XVilka XVilka deleted the asan-remove-dietline-global branch February 13, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
API dietline RzCons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XVilka @wargio