Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cons/grep: remove global state #4210

Merged
merged 1 commit into from
Feb 12, 2024
Merged

cons/grep: remove global state #4210

merged 1 commit into from
Feb 12, 2024

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Feb 12, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Remove globals and statics from the grep implementation.

Test plan

CI is green

Closing issues

Partially addresses #4055
Partially addresses #276

@wargio
Copy link
Member

wargio commented Feb 12, 2024

nice <3

@XVilka XVilka merged commit 86560ee into dev Feb 12, 2024
47 checks passed
@XVilka XVilka deleted the asan-remove-grep-globals branch February 12, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants