Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/analysis: remove globals #4057

Merged
merged 1 commit into from
Jan 1, 2024
Merged

core/analysis: remove globals #4057

merged 1 commit into from
Jan 1, 2024

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Dec 30, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

It's not the most beautiful and right way to do it, but the RzAnalysisEsil structure/context is so cursed already and will eventually be removed during the ESIL->RzIL migration that there is no reason to spend too much time on this.

Test plan

CI is green

Closing issues

Partially address #4055

@wargio wargio merged commit 26aacfe into dev Jan 1, 2024
47 checks passed
@XVilka XVilka deleted the asan-fix-globals branch January 1, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants