Skip to content

Conversation

@yossizap
Copy link
Member

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the rizin book with the relevant information (if needed)

Detailed description

v5 isn't going to be released officially anytime soon and there are new instructions like Intel's CET that aren't supported in v4. As long as the tests pass I don't see a reason not to do update.

Test plan

See that tests are green

@ret2libc
Copy link
Member

BTW, some code uses CSNEXT because acr/make defines that, however I think it is wrong and we should just use CS_API_MAJOR/CS_API_MINOR as usual.

@wargio
Copy link
Member

wargio commented Jan 17, 2021

TBH, it looks like capstone v5 has some wrong output.

Copy link
Member

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As previously said (here on mattermost, don't remember) you probably have to change analysis_riscv_cs.cto not use CSNEXT but check the CS_API_* defines as done elsewhere.

@XVilka
Copy link
Member

XVilka commented Jun 18, 2021

Could you please rebase this one? There are conflicts need to be resolved.

@XVilka
Copy link
Member

XVilka commented Nov 19, 2021

We should also update the subproject wraps since now the project moved to https://github.com/capstone-engine/capstone

@XVilka
Copy link
Member

XVilka commented Jul 20, 2022

@yossizap could you please rebase and solve the conflicts? Then we could see what is broken

@XVilka XVilka mentioned this pull request Jan 19, 2023
5 tasks
@XVilka
Copy link
Member

XVilka commented Jan 19, 2023

Closed in favor of #3301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

capstone infrastructure waiting-for-author Used to mark PRs where more work is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants