-
-
Notifications
You must be signed in to change notification settings - Fork 505
Set the default capstone version to v5 instead of v4 #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
BTW, some code uses |
|
TBH, it looks like capstone v5 has some wrong output. |
ret2libc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As previously said (here on mattermost, don't remember) you probably have to change analysis_riscv_cs.cto not use CSNEXT but check the CS_API_* defines as done elsewhere.
|
Could you please rebase this one? There are conflicts need to be resolved. |
|
We should also update the subproject wraps since now the project moved to https://github.com/capstone-engine/capstone |
|
@yossizap could you please rebase and solve the conflicts? Then we could see what is broken |
|
Closed in favor of #3301 |
Your checklist for this pull request
Detailed description
v5 isn't going to be released officially anytime soon and there are new instructions like Intel's CET that aren't supported in v4. As long as the tests pass I don't see a reason not to do update.
Test plan
See that tests are green