Skip to content

Add comment on load opcodes with the loaded value #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XVilka merged 1 commit into from
Jan 15, 2023
Merged

Add comment on load opcodes with the loaded value #3289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions librz/analysis/p/analysis_xtensa.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ static void xtensa_shr_op(RzAnalysis *analysis, RzAnalysisOp *op, ut64 addr, con
static void xtensa_l32r_op(RzAnalysis *analysis, RzAnalysisOp *op, ut64 addr, const ut8 *buf) {
op->type = RZ_ANALYSIS_OP_TYPE_LOAD;
op->ptr = ((addr + 3) & ~3) + ((buf[2] << 8 | buf[1]) << 2) - 0x40000;
op->refptr = 4;
}

static void xtensa_snm0_op(RzAnalysis *analysis, RzAnalysisOp *op, ut64 addr, const ut8 *buf) {
Expand Down
15 changes: 15 additions & 0 deletions test/db/analysis/xtensa
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,18 @@ var int32_t var_8h @ stack - 0x8
var int32_t var_4h @ stack - 0x4
EOF
RUN


NAME=xtensa l32r refptr
FILE=malloc://512
CMDS=<<EOF
e asm.arch=xtensa
e asm.bits=32
wx 00000000ff11ff1121ffff0df0ff
pD 3 @ 8
EOF
EXPECT=<<EOF
0x00000008 l32r a2, 0x00000004 ; [0x4:4]=0x11ff11ff
EOF
RUN