Skip to content

Use --werror with Linux Clang builds #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazarmy merged 3 commits into from
Nov 29, 2021
Merged

Use --werror with Linux Clang builds #2043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0c846f
Use `--werror` with Linux Clang builds
kazarmy Nov 29, 2021
e9006ea
Set `werror=false` in `capstone-bundled`'s `meson.build`
kazarmy Nov 29, 2021
da1f425
Allow through only `unneeded-internal-declaration` warning instead
kazarmy Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
build_system: meson
compiler: clang
run_tests: true
meson_options: -Dbuildtype=release
meson_options: -Dbuildtype=release --werror
enabled: ${{ (github.event_name != 'pull_request' || contains(github.head_ref, 'clang')) && needs.changes.outputs.edited == 'true' }}
timeout: 45
allow_failure: false
Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
build_system: meson
compiler: clang
cflags: '-DRZ_ASSERT_STDOUT=1 -Wno-cpp'
meson_options: -Dbuildtype=debugoptimized -Db_lundef=false -Db_sanitize=address,undefined -Duse_webui=true
meson_options: -Dbuildtype=debugoptimized -Db_lundef=false -Db_sanitize=address,undefined -Duse_webui=true --werror
asan: true
asan_options: 'detect_leaks=0,detect_odr_violation=0,allocator_may_return_null=1'
run_tests: true
Expand Down
6 changes: 5 additions & 1 deletion subprojects/packagefiles/capstone-bundled/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,11 @@ libcapstone_c_args = [
'-DCAPSTONE_HAS_X86',
'-DCAPSTONE_HAS_XCORE',
'-DCAPSTONE_HAS_TMS320C64X',
]
]
warn_unneeded_flag = '-Wno-error=unneeded-internal-declaration'
if meson.get_compiler('c').has_argument(warn_unneeded_flag)
libcapstone_c_args += warn_unneeded_flag
endif

libcapstone = library('capstone', cs_files,
c_args: libcapstone_c_args,
Expand Down