Skip to content

Conversation

@kazarmy
Copy link
Member

@kazarmy kazarmy commented Nov 28, 2021

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr fixes the following warning on the linux-meson-clang-tests build:

llabs
(https://github.com/rizinorg/rizin/runs/4342000656?check_suite_focus=true#step:12:553)

Test plan

All builds are green. The linux-meson-clang-tests build runs on this pr. The above warning is no longer emitted.

Closing issues

...

@kazarmy kazarmy marked this pull request as ready for review November 28, 2021 04:05
XVilka
XVilka previously approved these changes Nov 28, 2021
@kazarmy kazarmy marked this pull request as draft November 28, 2021 05:07
@kazarmy kazarmy marked this pull request as ready for review November 28, 2021 06:11
@kazarmy kazarmy requested a review from XVilka November 28, 2021 06:11
@kazarmy kazarmy dismissed XVilka’s stale review November 28, 2021 06:12

pr has changed significantly

@github-actions github-actions bot added the API label Nov 28, 2021
@kazarmy kazarmy merged commit 649f358 into dev Nov 28, 2021
@kazarmy kazarmy deleted the clang-Wabsolute-value-fix branch November 28, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants