fix #2952 - null deref in dyldcache.c

rizinorg · Aug 24, 2022 · a3e00b8 · a3e00b8
1 parent 8a96168
commit a3e00b8
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/librz/bin/format/mach0/dyldcache.c b/librz/bin/format/mach0/dyldcache.c
@@ -249,7 +249,7 @@ RZ_API objc_cache_opt_info *rz_dyldcache_get_objc_opt_info(RzBinFile *bf, RzDyld
 	RzListIter *iter;
 	RzDyldBinImage *bin;
 	rz_list_foreach (cache->bins, iter, bin) {
-		if (strcmp(bin->file, "lib/libobjc.A.dylib")) {
+		if (!bin->file || strcmp(bin->file, "lib/libobjc.A.dylib")) {
 			continue;
 		}
 
@@ -626,6 +626,8 @@ static RzList *create_cache_bins(RzDyldCache *cache) {
 					} else {
 						bin->file = strdup(file);
 					}
+				} else {
+					bin->file = rz_str_newf("unknown_image_%08" PFMT64x, symbols_off);
 				}
 				rz_list_append(bins, bin);
 				break;