Skip to content

remove Makefile on dev-asm#98

Merged
XVilka merged 1 commit intorizinorg:masterfrom
gogo2464:remove-makefile-documentation
Jun 23, 2023
Merged

remove Makefile on dev-asm#98
XVilka merged 1 commit intorizinorg:masterfrom
gogo2464:remove-makefile-documentation

Conversation

@gogo2464
Copy link
Contributor

@gogo2464 gogo2464 commented Jun 19, 2023

Fixes #97

Focuses on asm plugin only. Does not document meson on other plugins.

wargio
wargio reviewed Jun 19, 2023
View reviewed changes
XVilka
XVilka requested changes Jun 19, 2023
View reviewed changes
@wargio wargio changed the base branch from master to dev June 19, 2023 17:06
@wargio wargio changed the base branch from dev to master June 19, 2023 17:06
@gogo2464 gogo2464 force-pushed the remove-makefile-documentation branch from bcad7fd to 75fcc90 Compare June 20, 2023 18:09
wargio
wargio reviewed Jun 21, 2023
View reviewed changes
@gogo2464 gogo2464 force-pushed the remove-makefile-documentation branch from 75fcc90 to 7f89c56 Compare June 21, 2023 06:02
wargio
wargio reviewed Jun 21, 2023
View reviewed changes
@gogo2464 gogo2464 force-pushed the remove-makefile-documentation branch from 7f89c56 to 5fe5e8c Compare June 21, 2023 09:23
@gogo2464
Copy link
Contributor Author

gogo2464 commented Jun 21, 2023 •
edited
Loading

Seems good for me.

Sadly I have not really compiled the mycpu plugin.
Hopefully I have created my own plugin to handle evm: rizinorg/rizin#3595 so I can see.

@wargio
Copy link
Member

wargio commented Jun 21, 2023

can you add to the example the meson template?

@gogo2464
Copy link
Contributor Author

gogo2464 commented Jun 21, 2023

I believed I have already done https://github.com/rizinorg/book/pull/98/files#diff-cc0314ce2a2ce993dd86f5b416f5ece4ad633a55911c53f41c1b23a6ae688b16R89

@gogo2464 gogo2464 force-pushed the remove-makefile-documentation branch 5 times, most recently from 43c504e to dfbfa84 Compare June 21, 2023 17:27
@gogo2464
Copy link
Contributor Author

gogo2464 commented Jun 21, 2023

@wargio Did I forgot something?

wargio
wargio approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i misread it yesterday.

@gogo2464
Copy link
Contributor Author

gogo2464 commented Jun 22, 2023

Seems ready to merge @XVilka ?

@wargio wargio requested a review from XVilka June 22, 2023 13:33
XVilka
XVilka requested changes Jun 22, 2023
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added how to add it to a Rizin tree, but please also add a standalone Meson file, like it was done with Makefile before. You can see examples from rizin-extras how it can be done.

@gogo2464 gogo2464 force-pushed the remove-makefile-documentation branch from dfbfa84 to 530ffd8 Compare June 22, 2023 17:48
@gogo2464
Copy link
Contributor Author

gogo2464 commented Jun 22, 2023

@XVilka is it better now?

XVilka
XVilka requested changes Jun 22, 2023
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, what I meant, is you just need a meson file for just one particular plugin, just like this: https://github.com/rizinorg/rizin-extras/blob/master/jaguar-gpu/meson.build

@gogo2464 gogo2464 force-pushed the remove-makefile-documentation branch from 530ffd8 to b02fd7a Compare June 22, 2023 18:21
@gogo2464
Copy link
Contributor Author

gogo2464 commented Jun 22, 2023

I am confused... like this?

@XVilka XVilka merged commit efa4911 into rizinorg:master Jun 23, 2023
@gogo2464
Copy link
Contributor Author

gogo2464 commented Jun 23, 2023

@wargio @XVilka Does it pass GH-PAGES? I got a warning by email. :-/

nullun pushed a commit to nullun/book that referenced this pull request Sep 26, 2023
@gogo2464 @nullun
Remove Makefile on dev-asm (rizinorg#98)
0b53b30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XVilka XVilka XVilka approved these changes

@wargio wargio wargio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove Makefile from plugin dev

3 participants

@gogo2464 @wargio @XVilka