Skip to content

Commit

Permalink
expr: fix ~ update onig/onig_sys dependency (fix windows compilation …
Browse files Browse the repository at this point in the history
…bugs)

* fixes compile bugs blocking compilation "onig_sys" (required for `expr`) on windows
  - MSVC/VS tools are no longer required to be prepped and available on the PATH (via
    `vsvarsall` or the "VCX command prompt")
  - GNU `gcc` compilation/targets are possible on windows
* restrict onig version to v4.3.2 (or later patches [only]; see discussion)

.# Discussion

onig v4.3.0/v4.3.1 inadvertently introduced a new minimum rust version (requiring
v1.31+; see rust-onig/rust-onig#97). This was repaired with
v4.3.2 (requiring only v1.27.0+), and onig now specifies a rust minimum version that will
stay the same for patches, but may change between minor version increments.
  • Loading branch information
rivy committed Mar 13, 2019
1 parent 39b5760 commit e977e29
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/expr/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ path = "expr.rs"

[dependencies]
libc = "0.2.42"
onig = "3.1.1"
onig = "~4.3.2"
uucore = { path="../uucore" }

[[bin]]
Expand Down

0 comments on commit e977e29

Please sign in to comment.