Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare default settings and current settings and populate missing keys #142

Closed
wants to merge 5 commits into from
Closed

Compare default settings and current settings and populate missing keys #142

wants to merge 5 commits into from

Conversation

Gaisberg
Copy link
Collaborator

No description provided.

dreulavelle
dreulavelle requested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@dreulavelle dreulavelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move to generating/validating the settings based on a schema. Pydantic is good for this.

@dreulavelle
Copy link
Member

I can put this on my todo list if needed

@dreulavelle
Copy link
Member

Whats the status of this?

@AyushSehrawat
Copy link
Member

Closed as will be done with #204 by @omnunum

@dreulavelle dreulavelle deleted the feature/settings/check_keys branch February 25, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreulavelle dreulavelle dreulavelle requested changes

@AyushSehrawat AyushSehrawat Awaiting requested review from AyushSehrawat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gaisberg @dreulavelle @AyushSehrawat