Add: export ImageAsset and FontAsset types #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @cdelguercio! We'll get this integrated |
rive-engineering
pushed a commit
that referenced
this pull request
Nov 7, 2023
Community contribution PR: #337 Building on top of this contribution to expose the FontAsset types to the high-level API, which doesn't come by default when including it in `rive_advanced.mjs.d.ts` because the types exposed on high-level currently have to be set in `rive.ts` (otherwise, only the low-level API runtimes can access the types from `rive_advanced.mjs.d.ts`). Switched the OOB assets example to use TS to test this Diffs= 237f41f2a Add types for ImageAsset and FontAsset (#6213) Co-authored-by: Zachary Plata <[email protected]> Co-authored-by: cdelguercio <[email protected]>
|
This change was introduced from our upstream workflow and released in Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added so that I could cast a FileAsset to ImageAsset or FontAsset and call setRenderImage or setFont without TypeScript getting angry.