Skip to content

Commit

Permalink
tendon crash fix
Browse files Browse the repository at this point in the history
the current behavior of returning `StatusCode::FailedInversion;` when inversion fails was producing a crash. This was due to the fact that at the artboard level, we don't handle that error code in any specific way. So when a couple of lines later we call `onAddedDirty`, it tries to call `parent()->is<Skin>()`, and since parent() hasn't been set, it crashes.
This PR removes that error code and lets the app continue normally to mimic the editor behavior that allows for the inverse to fail, leaving it as an identity matrix.

Diffs=
a0f076e31 tendon crash fix (#6258)
  • Loading branch information
bodymovin committed Nov 20, 2023
1 parent 2df6145 commit 529e597
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .rive_head
Original file line number Diff line number Diff line change
@@ -1 +1 @@
c579540d144e3f89bc92149920e37eb78540888e
a0f076e31824c56cd13ad1cfe58597acdd90314e
2 changes: 1 addition & 1 deletion wasm/submodules/rive-cpp

0 comments on commit 529e597

Please sign in to comment.