-
Notifications
You must be signed in to change notification settings - Fork 767
feat(sink): introduce exactly once iceberg sink #19771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
5aa6703
add meta store in sink coordinator
wcy-fdu 4aba17b
iceberg sink write meta store
wcy-fdu 790db0b
save work
wcy-fdu 22e7fc3
save work
wcy-fdu f75b2c2
save work: sealize and deserialize pre commit metadata
wcy-fdu a0e6691
put recommit logic in coodinator.init()
wcy-fdu 9525615
clippy happy
wcy-fdu 7c938b1
delete meta store right after iceberg commit
wcy-fdu 6af8331
save work, todo: store sink metadata pb in meta store
wcy-fdu 45e53ce
save work, todo: add log_store_rewind_start_epoch in StartCoordinatio…
wcy-fdu 10b4d0d
save work
wcy-fdu 375895c
rewind log store
wcy-fdu 350d76e
update aws-lc-rs
wcy-fdu 6810374
save work
wcy-fdu 9cfb39a
fix meta store table name, verfify normal write path is right
wcy-fdu 64ce858
remove unrelated file
wcy-fdu 0f17d73
resolve conflict
wcy-fdu b315722
save work
wcy-fdu 7ada259
save work
wcy-fdu a94da79
resolve conflict
wcy-fdu d1b49de
update migration script to latest
wcy-fdu 59dd44e
resolve conflict
wcy-fdu 2d58f12
resolve some comments: add index, use snapshot_id to check file exist.
wcy-fdu 312e313
clean system table when drop sink
wcy-fdu 6f0db4e
add new interface for log reader to avoid change in rewind interface
wcy-fdu 63d9973
add change in log store for exactly once sink
wcy-fdu 7d4e7bc
minor
wcy-fdu e833faf
add comments
wcy-fdu 31cc794
change the semantics of rewind
wcy-fdu a70dd05
do not build stream when log_reader init()
wcy-fdu 0535d41
make clippy happy
wcy-fdu 169f277
do nothing for in memory log reader start_offset
wcy-fdu 5fa1177
merge change in pr 20772
wcy-fdu 7c8b64e
remove some old test
wcy-fdu c3f226c
sleep before and after iceberg commit for chaos mesh test
wcy-fdu 66393cd
skip rewind when all data already sinked and recovery happened
wcy-fdu deb49fc
save work
wcy-fdu e0740a8
add delete marker, fix some corner case, WIP, gc table
wcy-fdu 7863cea
delete previous item when commit
wcy-fdu fd9900d
add wait epoch berfore coordinator.commit
wcy-fdu ea3aa1f
do not sleep when re commit
wcy-fdu b163968
do not write system table when re commit, otherwise pk will conflict
wcy-fdu 9be29b7
tune test
wcy-fdu 6231d89
resolve some comments
wcy-fdu 65f91ca
resolve some comments
wcy-fdu f8ee260
resolve some comments
wcy-fdu abddb71
resolve comment
wcy-fdu d76108e
fix test
wcy-fdu 3348332
fix test
wcy-fdu 809052c
Merge branch 'main' of https://github.com/risingwavelabs/risingwave i…
wcy-fdu 308c8fb
minor fix
wcy-fdu 62b7e7f
minor refactor
wcy-fdu 2de4098
merge #20772
wcy-fdu 6a242c4
enhance tracing
wcy-fdu aa50691
keep migration script latest
wcy-fdu 03c6a56
minor
wcy-fdu 72d7739
sort cargo.toml
wcy-fdu 841e96a
minor
wcy-fdu 4b7a4cf
resolve conflict
wcy-fdu fc7a84c
only exactly once iceberg sink wait epoch before committing
wcy-fdu 1909886
Merge branch 'main' into wcy/exactlt_once_iceberg_sink.pr
wcy-fdu d6e2eff
Merge branch 'main' into wcy/exactlt_once_iceberg_sink.pr
wcy-fdu 21fd519
change bahavior when drop sink
wcy-fdu bb68fa4
Merge branch 'wcy/exactlt_once_iceberg_sink.pr' of https://github.com…
wcy-fdu 09466b1
minor
wcy-fdu 94c3227
clippy happy
wcy-fdu 12e56dd
Merge branch 'main' into wcy/exactlt_once_iceberg_sink.pr
wcy-fdu 0017444
empty commit for retry
wcy-fdu f243572
Merge branch 'wcy/exactlt_once_iceberg_sink.pr' of https://github.com…
wcy-fdu 639217a
do not handle system table when drop sink to wish CI pass
wcy-fdu 9348a0e
add #[cfg(not(madsim))] for drop sink
wcy-fdu 57fef17
resolve comments
wcy-fdu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will passing
DatabaseConnection::Disconnectedcause the iceberg sink bench to fail?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The iceberg sink will only write to the system table in one case, that is,
is_exactly_once = trueis set in the create sink statement. Otherwise, this DatabaseConnection will not be used.