Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nimtable): fix database path #19182

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix(nimtable): fix database path #19182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/connector/src/connector_common/iceberg/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ impl IcebergCommon {
"To create an iceberg engine table, NIMTABLE_DATA_DIRECTORY needed to be set"
);
};
let warehouse_path = format!("s3://{}/{}/nimtable", s3_bucket, data_directory);
let warehouse_path = format!("s3://{}/{}/nimtable/{}", s3_bucket, data_directory, self.database_name.clone().unwrap());

let (bucket, _) = {
let url = Url::parse(&warehouse_path)
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/src/handler/create_table.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1514,7 +1514,7 @@ pub async fn handle_create_table(
}
};

let warehouse_path = format!("s3://{}/{}/nimtable", s3_bucket, data_directory);
let warehouse_path = format!("s3://{}/{}/nimtable/{}", s3_bucket, data_directory, iceberg_catalog_name);

let mut sink_handler_args = handler_args.clone();
let mut with = BTreeMap::new();
Expand Down
Loading