ci: fix dashboard ci down by setup-protoc@v3#18754
ci: fix dashboard ci down by setup-protoc@v3#18754yihong0618 wants to merge 1 commit intorisingwavelabs:mainfrom yihong0618:fix_ci_protoc
Conversation
This patch fix the version mismatch for setup-protoc that make ci happy. Signed-off-by: yihong0618 <zouzou0208@gamil.com>
|
This action will not be triggered in ci unless proto files are modified. Please make sure it passes the CI. Also out release script is using protoc 3.15.8. Please be careful if you want bump it to 23.x |
yes right version can check https://github.com/yihong0618/risingwave/actions/runs/11090308904/job/30812486809 |
Shall we use |
not exactly, seems we need to set the version to latest |
|
https://github.com/arduino/setup-protoc/releases/tag/v2.0.0 Start from v2.0.0, setup-protoc only supports new protobuf version schema. That's why it does work with 3.x |
Thanks |
|
This PR has been open for 60 days with no activity. If it's blocked by code review, feel free to ping a reviewer or ask someone else to review it. If you think it is still relevant today, and have time to work on it in the near future, you can comment to update the status, or just manually remove the You can also confidently close this PR to keep our backlog clean. (If no further action taken, the PR will be automatically closed after 7 days. Sorry! 🙏) |
|
Close this PR as there's no further actions taken after it is marked as stale for 7 days. Sorry! 🙏 You can reopen it when you have time to continue working on it. |
This patch fix the version mismatch for setup-protoc that make ci happy.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR fix arduino/setup-protoc@v3 version is mismatch caused by #18710 by set the right version for it.
Wrong action: https://github.com/yihong0618/risingwave/actions/runs/11090307344
Right action by set it to the right version https://github.com/yihong0618/risingwave/actions/runs/11090308904/job/30812486809
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.