Skip to content

ci: fix dashboard ci down by setup-protoc@v3#18754

Closed
yihong0618 wants to merge 1 commit intorisingwavelabs:mainfrom
yihong0618:fix_ci_protoc
Closed

ci: fix dashboard ci down by setup-protoc@v3#18754
yihong0618 wants to merge 1 commit intorisingwavelabs:mainfrom
yihong0618:fix_ci_protoc

Conversation

@yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Sep 29, 2024

This patch fix the version mismatch for setup-protoc that make ci happy.

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR fix arduino/setup-protoc@v3 version is mismatch caused by #18710 by set the right version for it.

Wrong action: https://github.com/yihong0618/risingwave/actions/runs/11090307344
Right action by set it to the right version https://github.com/yihong0618/risingwave/actions/runs/11090308904/job/30812486809

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

This patch fix the version mismatch for setup-protoc that make ci
happy.

Signed-off-by: yihong0618 <zouzou0208@gamil.com>
@yuhao-su
Copy link
Contributor

This action will not be triggered in ci unless proto files are modified. Please make sure it passes the CI.

Also out release script is using protoc 3.15.8. Please be careful if you want bump it to 23.x

@yihong0618
Copy link
Contributor Author

This action will not be triggered in ci unless proto files are modified. Please make sure it passes the CI.

Also out release script is using protoc 3.15.8. Please be careful if you want bump it to 23.x

yes right version can check https://github.com/yihong0618/risingwave/actions/runs/11090308904/job/30812486809

@BugenZhao
Copy link
Contributor

Also out release script is using protoc 3.15.8.

Shall we use 26 instead? According to this:

https://github.com/protocolbuffers/protobuf/blob/436bd7880e458532901c58f4d9d1ea23fa7edd52/src/Makefile.am#L21

@yihong0618
Copy link
Contributor Author

Also out release script is using protoc 3.15.8.

Shall we use 26 instead? According to this:

https://github.com/protocolbuffers/protobuf/blob/436bd7880e458532901c58f4d9d1ea23fa7edd52/src/Makefile.am#L21

not exactly, seems we need to set the version to latest
according to this issue: arduino/setup-protoc#99

@yuhao-su
Copy link
Contributor

yuhao-su commented Sep 30, 2024

https://github.com/arduino/setup-protoc/releases/tag/v2.0.0 Start from v2.0.0, setup-protoc only supports new protobuf version schema. That's why it does work with 3.x

@yihong0618
Copy link
Contributor Author

https://github.com/arduino/setup-protoc/releases/tag/v2.0.0 Start from v2.0.0, setup-protoc only supports new protobuf version schema. That's why it does work with 3.x

Thanks

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

This PR has been open for 60 days with no activity.

If it's blocked by code review, feel free to ping a reviewer or ask someone else to review it.

If you think it is still relevant today, and have time to work on it in the near future, you can comment to update the status, or just manually remove the no-pr-activity label.

You can also confidently close this PR to keep our backlog clean. (If no further action taken, the PR will be automatically closed after 7 days. Sorry! 🙏)
Don't worry if you think the PR is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Close this PR as there's no further actions taken after it is marked as stale for 7 days. Sorry! 🙏

You can reopen it when you have time to continue working on it.

@github-actions github-actions bot closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants