Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add connector dev guide #17555

Merged
merged 7 commits into from
Jul 4, 2024
Merged

doc: add connector dev guide #17555

merged 7 commits into from
Jul 4, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jul 3, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#17436

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented Jul 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the component/doc Issues about documentation. label Jul 3, 2024
@xxchan xxchan requested a review from KeXiangWang July 3, 2024 18:39
@xxchan
Copy link
Member Author

xxchan commented Jul 3, 2024

@KeXiangWang I'm not sure whether this contains enough information or clear enough to help you develop #17429 .

Please tell me if it's not good enough, e.g.,:

  • missing information?
  • don't understand why to do so?
  • not actionable enough (don't know how to do some specific things)?
  • writing is not good?
  • or just too long and don't want to read?

🙏

@xxchan xxchan marked this pull request as ready for review July 4, 2024 03:28
@xxchan xxchan requested a review from BugenZhao July 4, 2024 03:28
Signed-off-by: xxchan <[email protected]>
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-organized and comprehensive. Very good

docs/dev/src/connector/intro.md Outdated Show resolved Hide resolved
docs/dev/src/connector/intro.md Outdated Show resolved Hide resolved
docs/dev/src/connector/intro.md Show resolved Hide resolved
xxchan and others added 2 commits July 4, 2024 13:52
Signed-off-by: xxchan <[email protected]>
@xxchan xxchan enabled auto-merge July 4, 2024 05:54
@xxchan xxchan added this pull request to the merge queue Jul 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2024
@xxchan xxchan added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 914c774 Jul 4, 2024
30 of 31 checks passed
@xxchan xxchan deleted the xxchan/optimistic-rabbit branch July 4, 2024 09:57
@xxchan
Copy link
Member Author

xxchan commented Jul 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/doc Issues about documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants