-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support config sql metastore using username and password by env #17530
Conversation
pub sql_username: String, | ||
/// Password of sql backend, required when meta backend set to MySQL or PostgreSQL. | ||
#[clap(long, default_value = "")] | ||
pub sql_password: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub sql_password: String, | |
pub sql_password: Secret<String>, |
Does this need to be secret as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. Do we need it? @zwang28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
…#17530) (#17737) Co-authored-by: August <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Resolve #16998 .
sqlite
,postgres
andmysql
in--backend
.--sql-username
,--sql-password
and--sql-database
, which only required forpostgres
andmysql
.--sql-endpoint
should be configured in format{host}:{port}
if the backend is set topostgres
andmysql
. Forsqlite
it should be the file path.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
Support configure sql metastore using username, password and database separately. The corresponding envs are also supported.
sqlite
,postgres
andmysql
in--backend
.--sql-username
,--sql-password
and--sql-database
, which only required forpostgres
andmysql
.--sql-endpoint
should be configured in format{host}:{port}
if the backend is set topostgres
andmysql
. Forsqlite
it should be the file path.