feat: add shutdown method to AsyncDB DB and Runner
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
xxchan
reviewed
Feb 6, 2025
sqllogictest-engines/src/postgres.rs
Outdated
| pub fn pg_client(&self) -> &tokio_postgres::Client { | ||
| &self.client | ||
| pub fn client(&self) -> &tokio_postgres::Client { | ||
| &self.conn.as_ref().expect("fuck").0 |
xxchan
reviewed
Feb 6, 2025
sqllogictest/src/runner.rs
Outdated
Comment on lines
538
to
543
| impl<D: AsyncDB, M: MakeConnection<Conn = D>> Drop for Runner<D, M> { | ||
| fn drop(&mut self) { | ||
| tracing::debug!("shutting down runner..."); | ||
| block_on(self.conn.shutdown_all()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Would block_on in drop be problematic? (If not, why don't we simply do it in impl Drop for Postgres without introducing a separate shutdown?
There was a problem hiding this comment.
This is a good point... 😕
There was a problem hiding this comment.
Updated to always let the caller handle shutdown.
Nice catch 👍 |
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
xxchan
approved these changes
Feb 7, 2025
|
unfortunately we need to bump the version :( |
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
changed the title
shutdown method to AsyncDBshutdown method to AsyncDB DB and Runner
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/shutdown
branch
from
4c22c2a to
018e24c
Compare
xxchan
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add
shutdownmethod toAsyncDB. Implement it for all engines. Adopt it in binary.Motivation
Previously we have a
Dropimpl forPostgreswhich directly aborts the background connection. This is not good as there's no chance for the pgwire protocol to gracefully shutdown itself. As a result, we seefailed to read message: unexpected end of fileevery time a test case (file) completes in the server side.Simply removing this
Dropimpl and letting the connection run to completion in the background resolves this issue. However, let's get one step further and propose a general design to all kinds of database engines by manually specifying and calling theshutdownmethod.Signed-off-by: Bugen Zhao [email protected]