Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all the project to the last version of idf.py and prebuilded ESP32S2 bin image #58

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ZhengLinLei
Copy link

Changes made:

  • More compatibility with new versions of idf.py (v5.x)
  • ESP32S2 bin image builded for easily flash
  • Changed ntohs function in library winsock.h
  • Changed the CMakeList to fix all the file or folder not found error with esp_wifi and esp_event components
  • Changed the interface folder to include so as not to cause confusion in future code maintenance.

Changes pending:

  • Change the server html and css design to more modern one.
  • Add more prebuilt bin images for different eso chip types

Thanks.

Zheng Lin Lei

@risinek
Copy link
Owner

risinek commented May 7, 2023

Thank you for contributing 👍 Try to polish the changes a bit, it's confusing as lot of unrelated changes are happening there. Try to find what exactly fixes the problem with missing header files, commit just this change and push it.
I guess the actual fix is adding

// Include library of ntohs function
#include <arpa/inet.h>

so it would be great if you can separate it from the rest of the changes and open PR with this particular change.

Also great idea to include builds for more chips 👍 I would suggest to create a folders in build dir like build/esp32, build/esp32s2, etc and then build the images into them, rather then creating branch for each chip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants