Remove [GT]PREL_[IS] internal binutils relocations#199
Merged
Conversation
These have never been emitted by GCC or Clang, nor has there ever been assembly syntax in either toolchain to create them. These are fake internal relocations inside binutils used as part of its implementation of linker relaxation, and so should not be part of the psABI. They should be free to be reallocated for psABI uses (which can include reintroducing them, if there is a need to expose them to assembly and code generation). Closes: #160
jrtc27
force-pushed
the
remove-internal-binutils-relocs
branch
from
3e012b8 to
297cac7
Compare
Contributor
|
Sounds right to me. |
Collaborator
|
LGTM |
1 similar comment
Collaborator
|
LGTM |
Contributor
|
I think that's enough LGTMs! |
asb
added a commit
to llvm/llvm-project
that referenced
this pull request
Nov 4, 2021
These relocations have been removed from the psABI doc in riscv-non-isa/riscv-elf-psabi-doc#199. This patch simply updates llvm/include/llvm/BinaryFormat/ELFRelocs/RISCV.def to match. Differential Revision: https://reviews.llvm.org/D112999
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
These relocations have been removed from the psABI doc in riscv-non-isa/riscv-elf-psabi-doc#199. This patch simply updates llvm/include/llvm/BinaryFormat/ELFRelocs/RISCV.def to match. Differential Revision: https://reviews.llvm.org/D112999
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These have never been emitted by GCC or Clang, nor has there ever been
assembly syntax in either toolchain to create them. These are fake
internal relocations inside binutils used as part of its implementation
of linker relaxation, and so should not be part of the psABI. They
should be free to be reallocated for psABI uses (which can include
reintroducing them, if there is a need to expose them to assembly and
code generation).
Closes: #160