-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requirement python3-tomli
#1614
Conversation
Why wouldn't this have triggered a problem here?
when this package isn't part of the prerequisites installation script?
|
If I understand correctly, you are using a GitHub Ubuntu Image, that has pre-installed tools. But, I cannot found |
The error is added with this patch. https://patchwork.kernel.org/project/qemu-devel/patch/[email protected]/ |
I have checked. GitHub Runner Ubuntu 22.04 image has |
I ran this a few days back on a fresh ubuntu 22.04 container from the LXD repo and I didn't have to install tomli, the build script of QEMU uses a python venv and installs needed packages itself. |
Does that mean that this issue/PR is moot and no change is needed? |
Nope it was my mistake, I installed QEMU 8.2 that used a bundled version of
tomli for fallback when building its venv. Since 9.2 systems with python <
3.10, such as 22.04, require tomli to be installed (recent python versions
include this already, so for example it's not a requirement for 24.04, for
more infos check out #1615.
…On Sun, Dec 15, 2024 at 7:54 PM Tommy Murphy ***@***.***> wrote:
I ran this a few days back on a fresh ubuntu 22.04 container from the LXD
repo and I didn't have to install tomli, the build script of QEMU uses a
python venv and installs needed packages itself.
Does that mean that this issue/PR is moot and no change is needed?
—
Reply to this email directly, view it on GitHub
<#1614 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADRMHJKRVS6MOAP6EYQWMT2FWQ3FAVCNFSM6AAAAABRZ32EE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTHEZDMMRRGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
GPG ID: 0xEE878588
As you read this post global entropy rises. Have Fun ;-)
Nick
|
Thanks @mickflemm - so this PR should be merged then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the package to https://github.com/riscv-collab/riscv-gnu-toolchain/blob/master/.github/setup-apt.sh
.
If it is there as well, we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
python3-tomli required for
build-sim SIM=qemu
in Ubuntu 22.04, I did not try other operating systems. fix #1615