This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
[FEATURE] Dismiss locale popup on Esc (RT-3280) #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jublo can we just make this a default? |
|
@vhpoet Sure—if there aren’t any popups that needs to run custom code on cancel? |
|
esc should call the same function as cancel |
|
so esc should just call |
|
unlock.jade popup has esc as cancel, but with different implementation. |
|
From my checks, these are the only 2 occurrences of the popup, so can I generalize the ESC button press as default for both of these? |
|
yep, esc should call popup.cancel |
Popup is dismissed when the user presses the [Esc] key while the popup is shown. This works for `rp-popup` directives only, not if the popup service is invoked directly.
|
|
|
LGTM |
1 similar comment
|
LGTM |
mrajvanshy
added a commit
that referenced
this pull request
May 11, 2015
[FEATURE] Dismiss locale popup on Esc (RT-3280)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
rp-popup(rp-popup-dismiss-on-esc)attribute to allow dismissing the popup when the user presses the [Esc] key while the popup is shown.