-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use IEnumerable
Dictionary
constructor
#755
Conversation
3ba19c4
to
5bf76b5
Compare
Codecov Report
@@ Coverage Diff @@
## main #755 +/- ##
==========================================
- Coverage 91.31% 91.30% -0.01%
==========================================
Files 201 201
Lines 6633 6651 +18
Branches 821 825 +4
==========================================
+ Hits 6057 6073 +16
- Misses 387 388 +1
- Partials 189 190 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR 😊
src/Riok.Mapperly/Descriptors/MappingBuilders/DictionaryMappingBuilder.cs
Outdated
Show resolved
Hide resolved
e9e8e2b
to
fcb1126
Compare
On second thoughts, should I close this PR and use the I was planning on later refactoring this when I add a version detector class for #732 and to speed up checks for versioned methods |
IMO if it is just a wrapper for the ctor we should use the ctor directly. |
004b76c
to
a9c7a6c
Compare
IEnumerable
Dictionary
constructor
a9c7a6c
to
474c6bf
Compare
src/Riok.Mapperly/Descriptors/MappingBuilders/DictionaryMappingBuilder.cs
Outdated
Show resolved
Hide resolved
474c6bf
to
eed7c40
Compare
src/Riok.Mapperly/Descriptors/MappingBuilders/DictionaryMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/DictionaryMappingBuilder.cs
Outdated
Show resolved
Hide resolved
0ab9fe9
to
b35aa7f
Compare
b35aa7f
to
2a3296c
Compare
🎉 This PR is included in version 3.3.0-next.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Use
IEnumerable
Dictionary
constructorDescription
Use the
IEnumerable
constructor if key and value mapping is synthetic.See #689
Checklist